New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce EventTrackingRegions::Event enum #558
Merged
Constellation
merged 0 commits into
WebKit:main
from
Constellation:eng/scrolling-event-names
May 9, 2022
Merged
Introduce EventTrackingRegions::Event enum #558
Constellation
merged 0 commits into
WebKit:main
from
Constellation:eng/scrolling-event-names
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
May 7, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 7, 2022
Constellation
removed
merging-blocked
Applied to prevent a change from being merged
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
May 7, 2022
Constellation
force-pushed
the
eng/scrolling-event-names
branch
from
May 7, 2022 20:03
7c727ef
to
c414c46
Compare
Constellation
added
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
May 7, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 7, 2022
Constellation
removed
merging-blocked
Applied to prevent a change from being merged
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
May 7, 2022
Constellation
force-pushed
the
eng/scrolling-event-names
branch
from
May 7, 2022 21:07
c414c46
to
290e876
Compare
Constellation
added
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
May 7, 2022
Constellation
force-pushed
the
eng/scrolling-event-names
branch
from
May 7, 2022 21:39
290e876
to
a55b011
Compare
MenloDorian
approved these changes
May 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with suggestions for improvement.
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
Outdated
Show resolved
Hide resolved
Constellation
commented
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
Outdated
Show resolved
Hide resolved
Constellation
force-pushed
the
eng/scrolling-event-names
branch
2 times, most recently
from
May 9, 2022 03:35
9bbdf68
to
e0e594c
Compare
Commit message contains (OOPS!), blocking PR #558 |
webkit-early-warning-system
added
merging-blocked
Applied to prevent a change from being merged
and removed
merge-queue
Applied to send a pull request to merge-queue
labels
May 9, 2022
Constellation
force-pushed
the
eng/scrolling-event-names
branch
from
May 9, 2022 06:15
e0e594c
to
36ca2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merging-blocked
Applied to prevent a change from being merged
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
36ca2e4