Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt CoreMedia API to use media parser daemon #5588

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Adopt CoreMedia API to use media parser daemon #5588

merged 1 commit into from
Oct 22, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Oct 20, 2022 •
edited by webkit-early-warning-system

8170bc8

Adopt CoreMedia API to use media parser daemon
https://bugs.webkit.org/show_bug.cgi?id=246805
rdar://99653449

Reviewed by Geoffrey Garen.

Adopt CoreMedia API to use media parser daemon. This requires access to the daemon in the GPU process's sandbox.

* Source/WebCore/PAL/pal/spi/cocoa/AVStreamDataParserSPI.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::SourceBufferParserAVFObjC):
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/255878@main

dc1a2f1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@pvollan pvollan self-assigned this Oct 20, 2022
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 349448a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@geoffreygaren
Copy link
Contributor

process' => process's (three s's in a row is weird! but correct.)

geoffreygaren
geoffreygaren approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan
Copy link
Contributor Author

pvollan commented Oct 22, 2022

r=me

Thanks for reviewing!

@pvollan pvollan force-pushed the eng/Adopt-CoreMedia-API-to-use-media-parser-daemon branch from 349448a to dc1a2f1 Compare October 22, 2022 00:58
@pvollan
Copy link
Contributor Author

pvollan commented Oct 22, 2022

process' => process's (three s's in a row is weird! but correct.)

Fixed!

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash dc1a2f1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Oct 22, 2022
@pvollan
Adopt CoreMedia API to use media parser daemon
8170bc8 
https://bugs.webkit.org/show_bug.cgi?id=246805
rdar://99653449

Reviewed by Geoffrey Garen.

Adopt CoreMedia API to use media parser daemon. This requires access to the daemon in the GPU process's sandbox.

* Source/WebCore/PAL/pal/spi/cocoa/AVStreamDataParserSPI.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::SourceBufferParserAVFObjC):
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/255878@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Adopt-CoreMedia-API-to-use-media-parser-daemon branch from dc1a2f1 to 8170bc8 Compare October 22, 2022 17:31
@webkit-commit-queue
Copy link
Collaborator

Committed 255878@main (8170bc8): https://commits.webkit.org/255878@main

Reviewed commits have been landed. Closing PR #5588 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8170bc8 into WebKit:main Oct 22, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@jernoble jernoble Awaiting requested review from jernoble

@jyavenard jyavenard Awaiting requested review from jyavenard

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @geoffreygaren @webkit-commit-queue