Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] Use std::optional<CSSNumberish>&& instead of std::optional<CSSNumberish> #5644

Merged
merged 1 commit into from Oct 22, 2022
Merged

[css-typed-om] Use std::optional<CSSNumberish>&& instead of std::optional<CSSNumberish> #5644

merged 1 commit into from Oct 22, 2022

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Oct 21, 2022 •
edited by webkit-early-warning-system

24da58a

[css-typed-om] Use `std::optional<CSSNumberish>&&` instead of `std::optional<CSSNumberish>`
https://bugs.webkit.org/show_bug.cgi?id=246881

Reviewed by Chris Dumez.

* Source/WebCore/css/typedom/transform/CSSScale.cpp:
(WebCore::CSSScale::create):
* Source/WebCore/css/typedom/transform/CSSScale.h:

Canonical link: https://commits.webkit.org/255864@main

d5d2866

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@graouts graouts self-assigned this Oct 21, 2022
@graouts graouts added CSS Cascading Style Sheets implementation Safari Technology Preview labels Oct 21, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 77f9875)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-wk1
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
  🛠 watch-sim ⏳ 🧪 mac-wk2-stress

@graouts graouts mentioned this pull request Oct 21, 2022
Merged
@graouts graouts requested a review from cdumez October 21, 2022 20:19
cdumez
cdumez approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graouts graouts force-pushed the css-scale-css-numberish-churn branch from 77f9875 to d5d2866 Compare October 21, 2022 20:22
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d5d2866)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@graouts graouts changed the title [css-typed-om] Use const std::optional<CSSNumberish>& instead of std::optional<CSSNumberish> [css-typed-om] Use std::optional<CSSNumberish>&& instead of std::optional<CSSNumberish> Oct 21, 2022
@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 22, 2022
@graouts
[css-typed-om] Use std::optional<CSSNumberish>&& instead of `std::o…
24da58a 
…ptional<CSSNumberish>`

https://bugs.webkit.org/show_bug.cgi?id=246881

Reviewed by Chris Dumez.

* Source/WebCore/css/typedom/transform/CSSScale.cpp:
(WebCore::CSSScale::create):
* Source/WebCore/css/typedom/transform/CSSScale.h:

Canonical link: https://commits.webkit.org/255864@main
@webkit-commit-queue
Copy link
Collaborator

Committed 255864@main (24da58a): https://commits.webkit.org/255864@main

Reviewed commits have been landed. Closing PR #5644 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 24da58a into WebKit:main Oct 22, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 22, 2022
@graouts graouts deleted the css-scale-css-numberish-churn branch October 22, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@graouts graouts

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@graouts @webkit-early-warning-system @webkit-commit-queue @cdumez