Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wdangling-pointer warning when building ANGLE with GCC 12 #566

Merged
merged 0 commits into from May 16, 2022
Merged

-Wdangling-pointer warning when building ANGLE with GCC 12 #566

merged 0 commits into from May 16, 2022

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented May 9, 2022 •
edited by webkit-early-warning-system

33377d8

-Wdangling-pointer warning when building ANGLE with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239339

Patch by Michael Catanzaro <mcatanzaro@gnome.org > on 2022-05-16
Reviewed by Yusuke Suzuki and Kenneth Russell.

* Source/ThirdParty/ANGLE/CMakeLists.txt:

Canonical link: https://commits.webkit.org/250617@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@mcatanzaro mcatanzaro self-assigned this May 9, 2022
@mcatanzaro mcatanzaro added ANGLE Bugs related to the ANGLE project WebKit Nightly Build labels May 9, 2022
@mcatanzaro mcatanzaro requested a review from kenrussell May 9, 2022 14:41
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 9, 2022
@mcatanzaro
Copy link
Contributor Author

ANGLE upstream thinks this might be a real bug, so let's leave the merging-blocked label for now.

Constellation
Constellation approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

kenrussell
kenrussell approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@mcatanzaro
Copy link
Contributor Author

ANGLE upstream thinks this might be a real bug, so let's leave the merging-blocked label for now.

Thanks for reviewing. I'll continue to wait for more comment from ANGLE upstream before merging. I thought for sure this was a false positive because it looked very intentional, but now I'm not so sure.

@mcatanzaro mcatanzaro added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 16, 2022
@mcatanzaro
Copy link
Contributor Author

ANGLE landed a change that did not actually fix the warning. Let's go with this option for now. I'll continue to follow the upstream issue https://bugs.chromium.org/p/angleproject/issues/detail?id=7288.

@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/-Wdangling-pointer-warning-when-building-ANGLE-with-GCC-12 branch from 5d58e6d to 33377d8 Compare May 16, 2022 22:36
@webkit-early-warning-system webkit-early-warning-system merged commit 33377d8 into WebKit:main May 16, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294271 (250617@main): https://commits.webkit.org/250617@main

Reviewed commits have been landed. Closing PR #566 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 16, 2022
@mcatanzaro mcatanzaro deleted the eng/-Wdangling-pointer-warning-when-building-ANGLE-with-GCC-12 branch July 7, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@kenrussell kenrussell kenrussell approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels
ANGLE Bugs related to the ANGLE project
Projects
None yet
Milestone
No milestone
4 participants
@mcatanzaro @webkit-early-warning-system @Constellation @kenrussell