Add coders for std::array and WTF::EnumeratedArray #5668
Conversation
heycam
added
WebKit Nightly Build
WebKit Process Model
|
EWS run on current version of this PR (hash b903808) |
| // We add 1 to the size because we expect that LastValue is the maximum value of the enum, | ||
| // rather than the count of items in the enum. | ||
| // We're assuming the values in the enum are zero-indexed. |
There was a problem hiding this comment.
Is this comment not useful?
There was a problem hiding this comment.
The fact that we assume the values are zero-based, and that LastValue is indeed the last value and not one past the last value, are already mentioned in the comment at the top of the class, a few lines up. I think the explanation of why we need to add 1 is reasonably self-evident, but I'm happy to leave it in if you prefer.
There was a problem hiding this comment.
Up to you. I'm the author of that comment so I think I'm biased :P
| { | ||
| std::array<std::optional<T>, size> items; | ||
|
|
||
| for (auto& item : items) { |
There was a problem hiding this comment.
Hey, that's nifty. The caller indicates how many items they expect, so there isn't a need to send the size across the wire.
There was a problem hiding this comment.
Yes, it's encoded in the type itself.
https://bugs.webkit.org/show_bug.cgi?id=246898 <rdar://problem/101453146> Reviewed by Myles C. Maxfield. * Source/WTF/wtf/EnumeratedArray.h: * Source/WTF/wtf/Forward.h: * Source/WebKit/Platform/IPC/ArgumentCoders.h: Canonical link: https://commits.webkit.org/255901@main
webkit-commit-queue
force-pushed
the
enumeratedarray-coder
branch
from
b903808
to
10f809a
Compare
|
Committed 255901@main (10f809a): https://commits.webkit.org/255901@main Reviewed commits have been landed. Closing PR #5668 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
10f809a
b903808