Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang build warning in WebSocketTaskCurl #5693

Merged
merged 1 commit into from Oct 24, 2022

Conversation

kshukuwa
Copy link
Contributor

@kshukuwa kshukuwa commented Oct 24, 2022

f10eb92

Fix clang build warning in WebSocketTaskCurl
https://bugs.webkit.org/show_bug.cgi?id=246847

Reviewed by Fujii Hironori.

A warning 'not handled in switch' is detected in WebSocketTask::didReceiveData()
due to 'OpCodeContinuation', 'OpCodePong' and 'OpCodeInvalid'. To solve the warning,
add those enum definitions.

* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::didReceiveData):

Canonical link: https://commits.webkit.org/255904@main

cf37457

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios   πŸ§ͺ api-mac   πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@kshukuwa kshukuwa requested a review from cdumez as a code owner October 24, 2022 01:59
@fujii fujii added the merge-queue Applied to send a pull request to merge-queue label Oct 24, 2022
https://bugs.webkit.org/show_bug.cgi?id=246847

Reviewed by Fujii Hironori.

A warning 'not handled in switch' is detected in WebSocketTask::didReceiveData()
due to 'OpCodeContinuation', 'OpCodePong' and 'OpCodeInvalid'. To solve the warning,
add those enum definitions.

* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::didReceiveData):

Canonical link: https://commits.webkit.org/255904@main
@webkit-commit-queue
Copy link
Collaborator

Committed 255904@main (f10eb92): https://commits.webkit.org/255904@main

Reviewed commits have been landed. Closing PR #5693 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 24, 2022
@kshukuwa kshukuwa deleted the bug246847 branch October 24, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants