Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use dashes when displaying built-products-dir argument. #5742

Merged
merged 1 commit into from Oct 26, 2022
Merged

Consistently use dashes when displaying built-products-dir argument. #5742

merged 1 commit into from Oct 26, 2022

Conversation

squelart
Copy link
Contributor

@squelart squelart commented Oct 25, 2022 •
edited by webkit-early-warning-system

@squelart squelart self-assigned this Oct 25, 2022
@squelart squelart added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Oct 25, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 6fe0fe2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 25, 2022
@alanbaradlay alanbaradlay added the merge-queue Applied to send a pull request to merge-queue label Oct 26, 2022
@grorg grorg removed the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022
@ryanhaddad ryanhaddad added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Oct 26, 2022
@squelart @ryanhaddad
Consistently use dashes when displaying built-products-dir argument.
45cd338 
https://bugs.webkit.org/show_bug.cgi?id=246988
<rdar://problem/101528104>

Reviewed by Jonathan Bedard.

* Tools/Scripts/generate-compile-commands:

Canonical link: https://commits.webkit.org/256031@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/generate-compile-commands--dashes-in-built-products-dir branch from 6fe0fe2 to 45cd338 Compare October 26, 2022 19:15
@webkit-commit-queue
Copy link
Collaborator

Committed 256031@main (45cd338): https://commits.webkit.org/256031@main

Reviewed commits have been landed. Closing PR #5742 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 45cd338 into WebKit:main Oct 26, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

Assignees

@squelart squelart

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
8 participants
@squelart @webkit-early-warning-system @webkit-commit-queue @JonWBedard @grorg @ryanhaddad @alanbaradlay @webkit-ews-buildbot