[WebCodecs] an encoder or decoder with being processed content should not be GCed #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
Media
|
EWS run on previous version of this PR (hash 2934176) |
webkit-commit-queue
added
merging-blocked
youennf
force-pushed
the
eng/WebCodecs-an-encoder-or-decoder-with-being-processed-content-should-not-be-GCed
branch
from
2934176
to
f18ae70
Compare
|
EWS run on current version of this PR (hash f18ae70)
|
youennf
added
merge-queue
… not be GCed https://bugs.webkit.org/show_bug.cgi?id=246995 rdar://problem/101533086 Reviewed by Eric Carlson. Add a counter for frames/chunks being processed by internal encoders/decoders. Make sure encoders and decoders are not GCed when the counter is not zero. * LayoutTests/TestExpectations: * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: (WebCore::WebCodecsVideoDecoder::decode): (WebCore::WebCodecsVideoDecoder::virtualHasPendingActivity const): * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: (WebCore::WebCodecsVideoEncoder::encode): (WebCore::WebCodecsVideoEncoder::virtualHasPendingActivity const): * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h: Canonical link: https://commits.webkit.org/256007@main
webkit-early-warning-system
force-pushed
the
eng/WebCodecs-an-encoder-or-decoder-with-being-processed-content-should-not-be-GCed
branch
from
f18ae70
to
856428a
Compare
|
Committed 256007@main (856428a): https://commits.webkit.org/256007@main Reviewed commits have been landed. Closing PR #5745 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
856428a
f18ae70
🛠 mac🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress