Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebCodecs] schedule dequeue event when encoder queue size decreases #5750

Merged
merged 1 commit into from Oct 25, 2022
Merged

[WebCodecs] schedule dequeue event when encoder queue size decreases #5750

merged 1 commit into from Oct 25, 2022

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Oct 25, 2022 •
edited by webkit-early-warning-system

9676c2c

[WebCodecs] schedule dequeue event when encoder queue size decreases
https://bugs.webkit.org/show_bug.cgi?id=247000
rdar://problem/101539115

Reviewed by Eric Carlson.

Schedule event as per spec.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::WebCodecsVideoEncoder::encode):

Canonical link: https://commits.webkit.org/255962@main

ee7e519

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@youennf youennf self-assigned this Oct 25, 2022
@youennf youennf added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build labels Oct 25, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ee7e519)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

eric-carlson
eric-carlson approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Oct 25, 2022
@youennf
[WebCodecs] schedule dequeue event when encoder queue size decreases
9676c2c 
https://bugs.webkit.org/show_bug.cgi?id=247000
rdar://problem/101539115

Reviewed by Eric Carlson.

Schedule event as per spec.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::WebCodecsVideoEncoder::encode):

Canonical link: https://commits.webkit.org/255962@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebCodecs-schedule-dequeue-event-when-encoder-queue-size-decreases branch from ee7e519 to 9676c2c Compare October 25, 2022 16:05
@webkit-commit-queue
Copy link
Collaborator

Committed 255962@main (9676c2c): https://commits.webkit.org/255962@main

Reviewed commits have been landed. Closing PR #5750 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9676c2c into WebKit:main Oct 25, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

Assignees

@youennf youennf

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@youennf @webkit-early-warning-system @webkit-commit-queue @eric-carlson