Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPUP] Enable media parser daemon #5773

Merged
merged 1 commit into from Dec 15, 2022
Merged

[GPUP] Enable media parser daemon #5773

merged 1 commit into from Dec 15, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Oct 25, 2022 •
edited by webkit-early-warning-system

5706da0

[GPUP] Enable media parser daemon
https://bugs.webkit.org/show_bug.cgi?id=247023
rdar://99653449

Reviewed by Chris Dumez and Geoffrey Garen.

Enable media parser daemon on iOS.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h:

Canonical link: https://commits.webkit.org/257919@main

fe56d18

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@pvollan pvollan self-assigned this Oct 25, 2022
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 25, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash f4df318)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
❌ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
❌ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
  🛠 🧪 jsc ✅ 🛠 tv ⏳ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

geoffreygaren
geoffreygaren approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan pvollan force-pushed the eng/GPUP-Enable-media-parser-daemon branch from f4df318 to acb7cfa Compare October 25, 2022 21:03
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash acb7cfa)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
✅ 🛠 ios-sim ❌ 🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc ❌ 🛠 tv ❌ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
❌ 🛠 tv-sim ❌ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@pvollan pvollan requested review from szewai and cdumez October 25, 2022 23:20
@pvollan pvollan force-pushed the eng/GPUP-Enable-media-parser-daemon branch from acb7cfa to 48cb90e Compare October 26, 2022 17:11
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 48cb90e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios ⏳ 🧪 api-mac   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ⏳ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@pvollan pvollan force-pushed the eng/GPUP-Enable-media-parser-daemon branch from 48cb90e to 32fe3bc Compare October 26, 2022 18:18
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 32fe3bc)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ❌ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 27, 2022
@pvollan
Copy link
Contributor Author

pvollan commented Dec 14, 2022

r=me

Thanks for reviewing!

@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 14, 2022
@pvollan pvollan force-pushed the eng/GPUP-Enable-media-parser-daemon branch from 32fe3bc to fe56d18 Compare December 14, 2022 08:08
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash fe56d18)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 15, 2022
@pvollan
[GPUP] Enable media parser daemon
5706da0 
https://bugs.webkit.org/show_bug.cgi?id=247023
rdar://99653449

Reviewed by Chris Dumez and Geoffrey Garen.

Enable media parser daemon on iOS.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h:

Canonical link: https://commits.webkit.org/257919@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257919@main (5706da0): https://commits.webkit.org/257919@main

Reviewed commits have been landed. Closing PR #5773 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 15, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 5706da0 into WebKit:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@szewai szewai Awaiting requested review from szewai

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
6 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @cdumez @geoffreygaren @webkit-ews-buildbot