"A MediaStreamTrack ended due to a capture failure" when selecting bluetooth headphones as audio input device #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 1cf874b)
|
eric-carlson
approved these changes
Oct 27, 2022
Comment on lines
178
to
180
| http/wpt/webcodecs [ Skip ] | ||
| imported/w3c/web-platform-tests/webcodecs [ Skip ] | ||
|
|
There was a problem hiding this comment.
Did you mean to include this?
Comment on lines
+33
to
+34
| await new Promise(resolve => setTimeout(resolve, 2000)); | ||
| assert_equals(track.readyState, "live"); |
There was a problem hiding this comment.
Rather than always waiting for two seconds, when most of the time that is much too long and sometimes it will be too short, it might be better to poll the attribute and fail if it doesn't change after some longer time.
There was a problem hiding this comment.
Here, we need to wait for the verification timer to kick in, so we need to wait 1 second.
I put 2 seconds just in case.
After 2 seconds, if the track is still live, we have recovered properly.
youennf
force-pushed
the
eng/A-MediaStreamTrack-ended-due-to-a-capture-failure-when-selecting-bluetooth-headphones-as-audio-input-device
branch
from
1cf874b
to
76813f1
Compare
|
EWS run on previous version of this PR (hash 76813f1) |
webkit-ews-buildbot
added
the
merging-blocked
youennf
force-pushed
the
eng/A-MediaStreamTrack-ended-due-to-a-capture-failure-when-selecting-bluetooth-headphones-as-audio-input-device
branch
from
76813f1
to
0525aa9
Compare
youennf
removed
the
merging-blocked
|
EWS run on current version of this PR (hash 0525aa9)
|
…uetooth headphones as audio input device https://bugs.webkit.org/show_bug.cgi?id=247119 rdar://problem/101628857 Reviewed by Eric Carlson. Replace the boolean to update the sample buffer by a minimum buffer sample frames, which is set when render fails. This minimum buffer sample frames is used to compute a minimum buffer size when setting up the audio unit. Update Mock implementation to cover that case. We do this by triggering this code path when triggerMockMicrophoneConfigurationChange is called. We also update the capture verification timer so that timer for mock unit is reduced to 1 second. Update LayoutTests/fast/mediastream/mediastreamtrack-configurationchange.html to cover that case. * LayoutTests/fast/mediastream/mediastreamtrack-configurationchange.html: * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp: (WebCore::CoreAudioSharedUnit::configureMicrophoneProc): (WebCore::CoreAudioSharedUnit::processMicrophoneSamples): (WebCore::CoreAudioSharedUnit::startInternal): (WebCore::CoreAudioSharedUnit::isProducingMicrophoneSamplesChanged): * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h: * Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h: * Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm: (WebCore::MockAudioSharedUnit::singleton): (WebCore::MockAudioSharedUnit::increaseBufferSize): (WebCore::MockAudioSharedInternalUnit::emitSampleBuffers): (WebCore::MockAudioSharedInternalUnit::render): * Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp: (WebCore::MockRealtimeMediaSourceCenter::triggerMockMicrophoneConfigurationChange): Canonical link: https://commits.webkit.org/256091@main
webkit-early-warning-system
force-pushed
the
eng/A-MediaStreamTrack-ended-due-to-a-capture-failure-when-selecting-bluetooth-headphones-as-audio-input-device
branch
from
0525aa9
to
b818b25
Compare
|
Committed 256091@main (b818b25): https://commits.webkit.org/256091@main Reviewed commits have been landed. Closing PR #5855 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b818b25
0525aa9
🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2