Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering artifacts when presenting fullscreen video #5883

Merged
merged 1 commit into from Nov 2, 2022
Merged

Rendering artifacts when presenting fullscreen video #5883

merged 1 commit into from Nov 2, 2022

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Oct 28, 2022 •
edited by webkit-early-warning-system

7df587c

Rendering artifacts when presenting fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=247155
rdar://101352957

Reviewed by Tim Horton.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):

Floor the values in the target size, as the window dimensions need to be integral values.

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

Canonical link: https://commits.webkit.org/256251@main

2a8f3ff

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@pxlcoder pxlcoder requested a review from cdumez as a code owner October 28, 2022 00:05
@pxlcoder pxlcoder self-assigned this Oct 28, 2022
@pxlcoder pxlcoder added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. Other labels Oct 28, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 2a8f3ff)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

hortont424
hortont424 approved these changes Oct 28, 2022
View reviewed changes
Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
@@ -577,7 +577,7 @@ - (void)enterFullScreen:(CGSize)videoDimensions
targetWidth = videoDimensions.width * preferredHeight / videoDimensions.height;
}

[_window setFrame:CGRectMake(0, 0, targetWidth, targetHeight)];
[_window setFrame:CGRectMake(0, 0, floorf(targetWidth), floorf(targetHeight))];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some preference for std::floor? (I have no idea)

@pxlcoder pxlcoder added the merge-queue Applied to send a pull request to merge-queue label Nov 2, 2022
@pxlcoder
Rendering artifacts when presenting fullscreen video
7df587c 
https://bugs.webkit.org/show_bug.cgi?id=247155
rdar://101352957

Reviewed by Tim Horton.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):

Floor the values in the target size, as the window dimensions need to be integral values.

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

Canonical link: https://commits.webkit.org/256251@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256251@main (7df587c): https://commits.webkit.org/256251@main

Reviewed commits have been landed. Closing PR #5883 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7df587c into WebKit:main Nov 2, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@grorg grorg Awaiting requested review from grorg

Assignees

@pxlcoder pxlcoder

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@pxlcoder @webkit-early-warning-system @webkit-commit-queue @hortont424