Implement StylePropertyMap::set() #5912

cdumez · 2022-10-28T16:04:55Z

`9d69bb3`

Implement StylePropertyMap::set()
https://bugs.webkit.org/show_bug.cgi?id=247199

Reviewed by Antti Koivisto.

Implement StylePropertyMap::set():
- https://drafts.css-houdini.org/css-typed-om/#dom-stylepropertymap-set

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/declared-styleMap-accepts-inherit-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/set-var-reference-thcrash-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/declared.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set.tentative-expected.txt:
* Source/WebCore/css/CSSProperty.cpp:
(WebCore::CSSProperty::createListForProperty):
* Source/WebCore/css/CSSProperty.h:
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setProperty):
* Source/WebCore/css/StyleProperties.h:
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::CSSCalcValue::create):
* Source/WebCore/css/calc/CSSCalcValue.h:
* Source/WebCore/css/typedom/CSSKeywordValue.cpp:
(WebCore::CSSKeywordValue::toCSSValue const):
* Source/WebCore/css/typedom/CSSKeywordValue.h:
* Source/WebCore/css/typedom/CSSNumericValue.h:
* Source/WebCore/css/typedom/CSSStyleImageValue.cpp:
(WebCore::CSSStyleImageValue::toCSSValue const):
* Source/WebCore/css/typedom/CSSStyleImageValue.h:
* Source/WebCore/css/typedom/CSSStyleValue.h:
(WebCore::CSSStyleValue::toCSSValue const):
(WebCore::CSSStyleValue::associatedProperty const):
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::vectorFromStyleValuesOrStrings):
* Source/WebCore/css/typedom/CSSStyleValueFactory.h:
* Source/WebCore/css/typedom/CSSUnitValue.cpp:
(WebCore::CSSUnitValue::toCSSValue const):
(WebCore::CSSUnitValue::toCalcExpressionNode const):
* Source/WebCore/css/typedom/CSSUnitValue.h:
* Source/WebCore/css/typedom/CSSUnparsedValue.cpp:
(WebCore::CSSUnparsedValue::toCSSValue const):
* Source/WebCore/css/typedom/CSSUnparsedValue.h:
* Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp:
(WebCore::DeclaredStylePropertyMap::setShorthandProperty):
(WebCore::DeclaredStylePropertyMap::setProperty):
(WebCore::DeclaredStylePropertyMap::setCustomProperty):
* Source/WebCore/css/typedom/DeclaredStylePropertyMap.h:
* Source/WebCore/css/typedom/StylePropertyMap.cpp:
(WebCore::cssValueFromStyleValues):
(WebCore::StylePropertyMap::set):
* Source/WebCore/css/typedom/StylePropertyMap.h:
* Source/WebCore/css/typedom/color/CSSColorValue.cpp:
(WebCore::CSSColorValue::toCSSValue const):
* Source/WebCore/css/typedom/color/CSSColorValue.h:
* Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp:
(WebCore::CSSMathClamp::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathClamp.h:
* Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp:
(WebCore::CSSMathInvert::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathInvert.h:
* Source/WebCore/css/typedom/numeric/CSSMathMax.cpp:
(WebCore::CSSMathMax::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathMax.h:
* Source/WebCore/css/typedom/numeric/CSSMathMin.cpp:
(WebCore::CSSMathMin::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathMin.h:
* Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp:
(WebCore::CSSMathNegate::equals const):
(WebCore::CSSMathNegate::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathNegate.h:
* Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp:
(WebCore::CSSMathProduct::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathProduct.h:
* Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:
(WebCore::CSSMathSum::toCalcExpressionNode const):
* Source/WebCore/css/typedom/numeric/CSSMathSum.h:
* Source/WebCore/css/typedom/numeric/CSSMathValue.h:
(WebCore::CSSMathValue::equalsImpl const):
* Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:
(WebCore::CSSMatrixComponent::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSMatrixComponent.h:
* Source/WebCore/css/typedom/transform/CSSPerspective.cpp:
(WebCore::CSSPerspective::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSPerspective.h:
* Source/WebCore/css/typedom/transform/CSSRotate.cpp:
(WebCore::CSSRotate::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSRotate.h:
* Source/WebCore/css/typedom/transform/CSSScale.cpp:
(WebCore::CSSScale::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSScale.h:
* Source/WebCore/css/typedom/transform/CSSSkew.cpp:
(WebCore::CSSSkew::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSSkew.h:
* Source/WebCore/css/typedom/transform/CSSSkewX.cpp:
(WebCore::CSSSkewX::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSSkewX.h:
* Source/WebCore/css/typedom/transform/CSSSkewY.cpp:
(WebCore::CSSSkewY::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSSkewY.h:
* Source/WebCore/css/typedom/transform/CSSTransformComponent.h:
* Source/WebCore/css/typedom/transform/CSSTransformValue.cpp:
(WebCore::CSSTransformValue::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSTransformValue.h:
* Source/WebCore/css/typedom/transform/CSSTranslate.cpp:
(WebCore::CSSTranslate::toCSSValue const):
* Source/WebCore/css/typedom/transform/CSSTranslate.h:
* Source/WebCore/dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::setInlineStyleCustomProperty):
* Source/WebCore/dom/StyledElement.h:

Canonical link: https://commits.webkit.org/256258@main

f379384

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-28T16:07:57Z

EWS run on previous version of this PR (hash 78ef9b5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-28T21:24:36Z

EWS run on previous version of this PR (hash 8bfa3d9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	❌ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-29T17:48:47Z

EWS run on previous version of this PR (hash 95e557d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
❌ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-29T22:07:53Z

EWS run on previous version of this PR (hash 9421e86)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-30T02:47:09Z

EWS run on previous version of this PR (hash d1e8517)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

cdumez · 2022-10-31T04:24:01Z

Source/WebCore/css/CSSPrimitiveValue.cpp


-    return computeNonCalcLengthDouble(conversionData, primitiveType(), m_value.num);
+    // FIXME: Without this, imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html would


@anttijk & @litherum I could really use your help here understanding what I am doing wrong. I have no idea why FontCascade::m_fonts is uninitialized here and how to fix it.

Note that that test in question was relying on StylePropertyMap::set() to actually run so there is also a small chance this exposed a pre-existing bug.

I think you can just skip the test. The crash involves the unrelated and less-than-complete registerProperty feature that is not a shipping configuration. I plan to work on it later.

webkit-early-warning-system · 2022-10-31T14:57:57Z

EWS run on previous version of this PR (hash d985947)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
❌ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

cdumez · 2022-11-01T19:26:42Z

Patch is ready for review.

webkit-early-warning-system · 2022-11-02T15:39:07Z

EWS run on current version of this PR (hash f379384)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=247199 Reviewed by Antti Koivisto. Implement StylePropertyMap::set(): - https://drafts.css-houdini.org/css-typed-om/#dom-stylepropertymap-set * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/declared-styleMap-accepts-inherit-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/set-var-reference-thcrash-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/declared.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set.tentative-expected.txt: * Source/WebCore/css/CSSProperty.cpp: (WebCore::CSSProperty::createListForProperty): * Source/WebCore/css/CSSProperty.h: * Source/WebCore/css/StyleProperties.cpp: (WebCore::MutableStyleProperties::setProperty): * Source/WebCore/css/StyleProperties.h: * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::CSSCalcValue::create): * Source/WebCore/css/calc/CSSCalcValue.h: * Source/WebCore/css/typedom/CSSKeywordValue.cpp: (WebCore::CSSKeywordValue::toCSSValue const): * Source/WebCore/css/typedom/CSSKeywordValue.h: * Source/WebCore/css/typedom/CSSNumericValue.h: * Source/WebCore/css/typedom/CSSStyleImageValue.cpp: (WebCore::CSSStyleImageValue::toCSSValue const): * Source/WebCore/css/typedom/CSSStyleImageValue.h: * Source/WebCore/css/typedom/CSSStyleValue.h: (WebCore::CSSStyleValue::toCSSValue const): (WebCore::CSSStyleValue::associatedProperty const): * Source/WebCore/css/typedom/CSSStyleValueFactory.cpp: (WebCore::CSSStyleValueFactory::vectorFromStyleValuesOrStrings): * Source/WebCore/css/typedom/CSSStyleValueFactory.h: * Source/WebCore/css/typedom/CSSUnitValue.cpp: (WebCore::CSSUnitValue::toCSSValue const): (WebCore::CSSUnitValue::toCalcExpressionNode const): * Source/WebCore/css/typedom/CSSUnitValue.h: * Source/WebCore/css/typedom/CSSUnparsedValue.cpp: (WebCore::CSSUnparsedValue::toCSSValue const): * Source/WebCore/css/typedom/CSSUnparsedValue.h: * Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp: (WebCore::DeclaredStylePropertyMap::setShorthandProperty): (WebCore::DeclaredStylePropertyMap::setProperty): (WebCore::DeclaredStylePropertyMap::setCustomProperty): * Source/WebCore/css/typedom/DeclaredStylePropertyMap.h: * Source/WebCore/css/typedom/StylePropertyMap.cpp: (WebCore::cssValueFromStyleValues): (WebCore::StylePropertyMap::set): * Source/WebCore/css/typedom/StylePropertyMap.h: * Source/WebCore/css/typedom/color/CSSColorValue.cpp: (WebCore::CSSColorValue::toCSSValue const): * Source/WebCore/css/typedom/color/CSSColorValue.h: * Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp: (WebCore::CSSMathClamp::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathClamp.h: * Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp: (WebCore::CSSMathInvert::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathInvert.h: * Source/WebCore/css/typedom/numeric/CSSMathMax.cpp: (WebCore::CSSMathMax::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathMax.h: * Source/WebCore/css/typedom/numeric/CSSMathMin.cpp: (WebCore::CSSMathMin::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathMin.h: * Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp: (WebCore::CSSMathNegate::equals const): (WebCore::CSSMathNegate::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathNegate.h: * Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp: (WebCore::CSSMathProduct::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathProduct.h: * Source/WebCore/css/typedom/numeric/CSSMathSum.cpp: (WebCore::CSSMathSum::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathSum.h: * Source/WebCore/css/typedom/numeric/CSSMathValue.h: (WebCore::CSSMathValue::equalsImpl const): * Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp: (WebCore::CSSMatrixComponent::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSMatrixComponent.h: * Source/WebCore/css/typedom/transform/CSSPerspective.cpp: (WebCore::CSSPerspective::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSPerspective.h: * Source/WebCore/css/typedom/transform/CSSRotate.cpp: (WebCore::CSSRotate::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSRotate.h: * Source/WebCore/css/typedom/transform/CSSScale.cpp: (WebCore::CSSScale::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSScale.h: * Source/WebCore/css/typedom/transform/CSSSkew.cpp: (WebCore::CSSSkew::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSSkew.h: * Source/WebCore/css/typedom/transform/CSSSkewX.cpp: (WebCore::CSSSkewX::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSSkewX.h: * Source/WebCore/css/typedom/transform/CSSSkewY.cpp: (WebCore::CSSSkewY::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSSkewY.h: * Source/WebCore/css/typedom/transform/CSSTransformComponent.h: * Source/WebCore/css/typedom/transform/CSSTransformValue.cpp: (WebCore::CSSTransformValue::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSTransformValue.h: * Source/WebCore/css/typedom/transform/CSSTranslate.cpp: (WebCore::CSSTranslate::toCSSValue const): * Source/WebCore/css/typedom/transform/CSSTranslate.h: * Source/WebCore/dom/StyledElement.cpp: (WebCore::StyledElement::setInlineStyleProperty): (WebCore::StyledElement::setInlineStyleCustomProperty): * Source/WebCore/dom/StyledElement.h: Canonical link: https://commits.webkit.org/256258@main

webkit-commit-queue · 2022-11-03T00:10:32Z

Committed 256258@main (9d69bb3): https://commits.webkit.org/256258@main

Reviewed commits have been landed. Closing PR #5912 and removing active labels.

cdumez self-assigned this Oct 28, 2022

cdumez added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Oct 28, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

cdumez force-pushed the StylePropertyMap branch from 78ef9b5 to 8bfa3d9 Compare October 28, 2022 21:24

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 29, 2022

cdumez force-pushed the StylePropertyMap branch from 8bfa3d9 to 95e557d Compare October 29, 2022 17:48

cdumez force-pushed the StylePropertyMap branch from 95e557d to 9421e86 Compare October 29, 2022 22:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 29, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 30, 2022

cdumez force-pushed the StylePropertyMap branch from 9421e86 to d1e8517 Compare October 30, 2022 02:47

cdumez commented Oct 31, 2022

View reviewed changes

cdumez force-pushed the StylePropertyMap branch from d1e8517 to d985947 Compare October 31, 2022 14:57

cdumez marked this pull request as ready for review October 31, 2022 23:32

cdumez requested a review from rniwa as a code owner October 31, 2022 23:32

cdumez requested review from anttijk, achristensen07, graouts and geoffreygaren October 31, 2022 23:32

anttijk approved these changes Nov 2, 2022

View reviewed changes

cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 2, 2022

webkit-early-warning-system force-pushed the StylePropertyMap branch from d985947 to a775d0b Compare November 2, 2022 14:42

cdumez removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 2, 2022

cdumez force-pushed the StylePropertyMap branch from a775d0b to f379384 Compare November 2, 2022 15:36

cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 3, 2022

webkit-commit-queue force-pushed the StylePropertyMap branch from f379384 to 9d69bb3 Compare November 3, 2022 00:10

webkit-commit-queue merged commit 9d69bb3 into WebKit:main Nov 3, 2022

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement StylePropertyMap::set() #5912

Implement StylePropertyMap::set() #5912

cdumez commented Oct 28, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 29, 2022 •

edited

webkit-early-warning-system commented Oct 29, 2022 •

edited

webkit-early-warning-system commented Oct 30, 2022 •

edited

cdumez Oct 31, 2022

anttijk Oct 31, 2022

webkit-early-warning-system commented Oct 31, 2022 •

edited

cdumez commented Nov 1, 2022

webkit-early-warning-system commented Nov 2, 2022 •

edited

webkit-commit-queue commented Nov 3, 2022


		return computeNonCalcLengthDouble(conversionData, primitiveType(), m_value.num);
		// FIXME: Without this, imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html would

Implement StylePropertyMap::set() #5912

Implement StylePropertyMap::set() #5912

Conversation

cdumez commented Oct 28, 2022 • edited by webkit-early-warning-system

9d69bb3

webkit-early-warning-system commented Oct 28, 2022 • edited

webkit-early-warning-system commented Oct 28, 2022 • edited

webkit-early-warning-system commented Oct 29, 2022 • edited

webkit-early-warning-system commented Oct 29, 2022 • edited

webkit-early-warning-system commented Oct 30, 2022 • edited

cdumez Oct 31, 2022

Choose a reason for hiding this comment

anttijk Oct 31, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Oct 31, 2022 • edited

cdumez commented Nov 1, 2022

webkit-early-warning-system commented Nov 2, 2022 • edited

webkit-commit-queue commented Nov 3, 2022

cdumez commented Oct 28, 2022 •

edited by webkit-early-warning-system

`9d69bb3`

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 28, 2022 •

edited

webkit-early-warning-system commented Oct 29, 2022 •

edited

webkit-early-warning-system commented Oct 29, 2022 •

edited

webkit-early-warning-system commented Oct 30, 2022 •

edited

webkit-early-warning-system commented Oct 31, 2022 •

edited

webkit-early-warning-system commented Nov 2, 2022 •

edited