Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties #5917

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 28, 2022

fd2b5bf

Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties
https://bugs.webkit.org/show_bug.cgi?id=247205

Reviewed by Antti Koivisto.

Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties:
- https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parse
- https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parseall

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string-expected.txt:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractShorthandCSSValues):
(WebCore::CSSStyleValueFactory::parseStyleValue):
* Source/WebCore/css/typedom/CSSStyleValueFactory.h:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
(WebCore::MainThreadStylePropertyMapReadOnly::shorthandPropertyValue const):

Canonical link: https://commits.webkit.org/256228@main

2fbb312

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@cdumez cdumez self-assigned this Oct 28, 2022
@cdumez cdumez added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Oct 28, 2022
@cdumez cdumez marked this pull request as ready for review October 31, 2022 23:32
@cdumez
Copy link
Contributor Author

cdumez commented Nov 1, 2022

Patch is ready for review.

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 2, 2022
https://bugs.webkit.org/show_bug.cgi?id=247205

Reviewed by Antti Koivisto.

Fix CSSStyleValue.parse() / parseAll() for shorthand CSS properties:
- https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parse
- https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-parseall

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string-expected.txt:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractShorthandCSSValues):
(WebCore::CSSStyleValueFactory::parseStyleValue):
* Source/WebCore/css/typedom/CSSStyleValueFactory.h:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
(WebCore::MainThreadStylePropertyMapReadOnly::shorthandPropertyValue const):

Canonical link: https://commits.webkit.org/256228@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256228@main (fd2b5bf): https://commits.webkit.org/256228@main

Reviewed commits have been landed. Closing PR #5917 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit fd2b5bf into WebKit:main Nov 2, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
4 participants