Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded check in HTMLSlotElement::assignedNodes() #598

Merged
merged 0 commits into from May 13, 2022
Merged

Remove unneeded check in HTMLSlotElement::assignedNodes() #598

merged 0 commits into from May 13, 2022

Conversation

mrego
Copy link
Member

@mrego mrego commented May 12, 2022 •
edited by webkit-early-warning-system

ce78fdf

Remove unneeded check in HTMLSlotElement::assignedNodes()
https://bugs.webkit.org/show_bug.cgi?id=240340

Reviewed by Ryosuke Niwa.

* html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::assignedNodes const):

Canonical link: https://commits.webkit.org/250514@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@mrego mrego self-assigned this May 12, 2022
@mrego mrego changed the title Remove unneeded check in if Remove unneeded check in HTMLSlotElement::assignedNodes() May 12, 2022
@mrego mrego added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels May 12, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 12, 2022
@mrego
Copy link
Member Author

mrego commented May 12, 2022

Not sure how I can re-trigger a EWS as the failure seems totally unrelated, so I'm trying removing the merging-block label.

@mrego mrego removed the merging-blocked Applied to prevent a change from being merged label May 12, 2022
@mrego
Copy link
Member Author

mrego commented May 12, 2022

Now a new try closing and reopening the PR.

@mrego mrego closed this May 12, 2022
@mrego mrego reopened this May 12, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 12, 2022
rniwa
rniwa approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@mrego mrego removed merging-blocked Applied to prevent a change from being merged DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels May 13, 2022
@mrego mrego added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build merge-queue Applied to send a pull request to merge-queue labels May 13, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit ce78fdf into WebKit:main May 13, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294144 (250514@main): https://commits.webkit.org/250514@main

Reviewed commits have been landed. Closing PR #598 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 13, 2022
@mrego mrego deleted the simple-fix branch May 13, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

Assignees

@mrego mrego

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
3 participants
@mrego @webkit-early-warning-system @rniwa