Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MiniBrowser settings menu construction #5992

Commits on Nov 1, 2022

  1. Simplify MiniBrowser settings menu construction

    https://bugs.webkit.org/show_bug.cgi?id=247305
    
    Reviewed by Simon Fraser.
    
    * Tools/MiniBrowser/mac/SettingsController.m:
    (-[SettingsController initWithMenu:]):
    (addItemToMenuWithTarget):
    (addSeparatorToMenu):
    (addSubmenuToMenu):
    (-[SettingsController _populateMenu:]):
    (-[SettingsController buildUserAgentsMenu:]):
    (-[SettingsController validateMenuItem:]):
    (-[SettingsController changeCustomUserAgent:]):
    (-[SettingsController dealloc]): Deleted.
    (-[SettingsController _addItemWithTitle:action:indented:]): Deleted.
    (-[SettingsController _addHeaderWithTitle:]): Deleted.
    (-[SettingsController _populateMenu]): Deleted.
    (-[SettingsController changeCutomUserAgent:]): Deleted.
    Simplify the menu construction with some more helper functions.
    Move the resource usage overlays into the overlay submenu.
    Remove the empty WebKit1-only settings section.
    Fix some typos.
    
    Canonical link: https://commits.webkit.org/256195@main
    hortont424 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d8123ac View commit details
    Browse the repository at this point in the history