Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git-webkit] Open closed pull-request when running pr (Follow-up fix) #60

Merged
merged 0 commits into from Jan 4, 2022
Merged

[git-webkit] Open closed pull-request when running pr (Follow-up fix) #60

merged 0 commits into from Jan 4, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 4, 2022 •
edited

1209d80

[git-webkit] Open closed pull-request when running pr (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=232765
<rdar://problem/85084318 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): Log found pull-request instead of undefined candidates.


Canonical link: https://commits.webkit.org/245716@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Jan 4, 2022
dewei-zhu
dewei-zhu approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard merged commit 1209d80 into WebKit:main Jan 4, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/245716@main (1209d80)!

@JonWBedard JonWBedard deleted the eng/fix-failed-pr-logging branch January 4, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@aj062 aj062 Awaiting requested review from aj062

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JonWBedard @dewei-zhu