Support modules for web extension service workers. #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 69c984c)
|
webkit-ews-buildbot
added
the
merging-blocked
xeenon
requested changes
Nov 1, 2022
eepskamp
force-pushed
the
eng/Support-modules-for-web-extension-service-workers
branch
from
69c984c
to
fc79029
Compare
|
EWS run on current version of this PR (hash fc79029) |
xeenon
approved these changes
Nov 2, 2022
xeenon
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=247325 rdar://100429656 Reviewed by Timothy Hatcher. Revise SPI to load a service worker to include a parameter that indicates if the service worker uses modules or not. Parse the "module" type from the extension's manifest and use that to load the service worker correctly, or to create the generated background HTML file with the correct <script> elements. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _loadServiceWorker:usingModules:completionHandler:]): (-[WKWebView _loadServiceWorker:completionHandler:]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm: (-[_WKWebExtension backgroundContentUsesModules]): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::backgroundContentUsesModules): (WebKit::WebExtension::generatedBackgroundContent): (WebKit::WebExtension::populateBackgroundPropertiesIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadBackgroundWebView): * Source/WebKit/UIProcess/Extensions/WebExtension.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadServiceWorker): * Source/WebKit/UIProcess/WebPageProxy.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/256257@main
webkit-early-warning-system
force-pushed
the
eng/Support-modules-for-web-extension-service-workers
branch
from
fc79029
to
ba3a201
Compare
|
Committed 256257@main (ba3a201): https://commits.webkit.org/256257@main Reviewed commits have been landed. Closing PR #6010 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ba3a201
fc79029
🛠 mac🧪 api-ios🧪 api-mac🧪 mac-wk1🧪 mac-AS-debug-wk2