New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wasm-GC] Begin importing GC spec tests #6067
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
takikawa:eng/Wasm-GC-Begin-importing-GC-spec-tests
Nov 7, 2022
Merged
[Wasm-GC] Begin importing GC spec tests #6067
webkit-commit-queue
merged 1 commit into
WebKit:main
from
takikawa:eng/Wasm-GC-Begin-importing-GC-spec-tests
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takikawa
added
WebAssembly
For bugs in JavaScript WebAssembly
WebKit Nightly Build
labels
Nov 3, 2022
EWS run on previous version of this PR (hash 0e64418) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 5, 2022
takikawa
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 5, 2022
takikawa
force-pushed
the
eng/Wasm-GC-Begin-importing-GC-spec-tests
branch
from
November 5, 2022 23:13
0e64418
to
fa454d2
Compare
EWS run on current version of this PR (hash fa454d2) |
justinmichaud
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=247336 Reviewed by Justin Michaud. This patch creates a Wasm GC proposal spec test harness and test suite from the upstream repository at https://github.com/WebAssembly/gc (commit 5404857b61a42b4d9fdd99f6b78d8febb266f1fc) The tests contain a subset of the upstream tests that are currently runnable in JSC. Some of the tests are commented out due to open bugs that block them. In addition, this patch fixes a small bug (a missing type expansion use) revealed by the tests. * JSTests/wasm.yaml: * JSTests/wasm/gc-spec-harness.js: Added. (import.string_appeared_here.then): (test): (promise_test): (let.assert_unreached): (let.console.log): * JSTests/wasm/gc-spec-harness/async_index.js: Added. (let.testNum): (uniqueTest): (assertThrows): (externref): (is_externref): (is_funcref): (eq_externref): (eq_funcref): (binary): (module): (assert_invalid): (instance): (exports): (then.): (reinitializeRegistry.get promise_test): (reinitializeRegistry): (catch): (assert_exhaustion): (get const): * JSTests/wasm/gc-spec-harness/sync_index.js: Added. (let.testNum): (assertThrows): (_assert): (ValueResult): (ErrorResult): (Result.prototype.isError): (externref): (is_externref): (is_funcref): (eq_externref): (eq_funcref): (reinitializeRegistry.let.handler.get return): (binary): (module): * JSTests/wasm/gc-spec-tests/type-canon.wast.js: Added. * JSTests/wasm/gc-spec-tests/type-equivalence.wast.js: Added. * JSTests/wasm/gc-spec-tests/type-rec.wast.js: Added. * JSTests/wasm/gc-spec-tests/type-subtyping.wast.js: Added. * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::jsCallEntrypointSlow): * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/256417@main
webkit-commit-queue
force-pushed
the
eng/Wasm-GC-Begin-importing-GC-spec-tests
branch
from
November 7, 2022 19:06
fa454d2
to
8ac6345
Compare
Committed 256417@main (8ac6345): https://commits.webkit.org/256417@main Reviewed commits have been landed. Closing PR #6067 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8ac6345
fa454d2
π§ͺ mac-wk1