Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][WebRTC] Minor cleanups in IncomingSourceGStreamer #6082

Merged
merged 1 commit into from Nov 7, 2022

Conversation

philn
Copy link
Member

@philn philn commented Nov 3, 2022

25fd484

[GStreamer][WebRTC] Minor cleanups in IncomingSourceGStreamer
https://bugs.webkit.org/show_bug.cgi?id=247423

Reviewed by Xabier Rodriguez-Calvar.

There is no need for a queue between the valve and the tee. Utility methods for opening/closing now
un-needed were removed as well.

* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::RealtimeIncomingSourceGStreamer):
(WebCore::RealtimeIncomingSourceGStreamer::startProducingData):
(WebCore::RealtimeIncomingSourceGStreamer::stopProducingData):
(WebCore::RealtimeIncomingSourceGStreamer::closeValve const): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::openValve const): Deleted.
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:

Canonical link: https://commits.webkit.org/256393@main

a11d375

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@philn philn self-assigned this Nov 3, 2022
@philn philn added Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebKit Nightly Build labels Nov 3, 2022
@philn philn requested a review from calvaris November 3, 2022 15:52
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 5, 2022
@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=247423

Reviewed by Xabier Rodriguez-Calvar.

There is no need for a queue between the valve and the tee. Utility methods for opening/closing now
un-needed were removed as well.

* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::RealtimeIncomingSourceGStreamer):
(WebCore::RealtimeIncomingSourceGStreamer::startProducingData):
(WebCore::RealtimeIncomingSourceGStreamer::stopProducingData):
(WebCore::RealtimeIncomingSourceGStreamer::closeValve const): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::openValve const): Deleted.
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:

Canonical link: https://commits.webkit.org/256393@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256393@main (25fd484): https://commits.webkit.org/256393@main

Reviewed commits have been landed. Closing PR #6082 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 25fd484 into WebKit:main Nov 7, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 7, 2022
@philn philn deleted the eng/247423 branch November 7, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
5 participants