Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EWS] Support pull-requests in ConfigureBuild #61

Merged
merged 0 commits into from Jan 6, 2022
Merged

[EWS] Support pull-requests in ConfigureBuild #61

merged 0 commits into from Jan 6, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 4, 2022 •
edited

d3095e8

[EWS] Support pull-requests in ConfigureBuild
https://bugs.webkit.org/show_bug.cgi?id=234848
<rdar://problem/87094989 >

Reviewed by Dewei Zhu.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.pr_url): Map pull-request number to URL.
(GitHubMixin.get_pull_request_number): Check if the event triggering
this was a pull_request, and the specified branch can be mapped to a
pull-request.
(ConfigureBuild.start): Add pull-request details.
(ConfigureBuild.add_pr_details): Ditto.


Canonical link: https://commits.webkit.org/245802@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Jan 4, 2022
@JonWBedard JonWBedard requested a review from aj062 January 4, 2022 17:31
@JonWBedard JonWBedard force-pushed the eng/github-ews-configure-build branch 4 times, most recently from d8d3e21 to 2198a22 Compare January 4, 2022 23:00
dewei-zhu
dewei-zhu approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard merged commit d3095e8 into WebKit:main Jan 6, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/245802@main (d3095e8)!

@JonWBedard JonWBedard force-pushed the eng/github-ews-configure-build branch from 2198a22 to d3095e8 Compare January 6, 2022 23:19
@JonWBedard JonWBedard deleted the eng/github-ews-configure-build branch January 6, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@aj062 aj062 Awaiting requested review from aj062

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JonWBedard @dewei-zhu