JetStream driver should ignore references to URL parameters when run in jsc shell
#6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xw
added
Other
Tools / Tests
|
EWS run on current version of this PR (hash c164c98)
|
…in `jsc` shell https://bugs.webkit.org/show_bug.cgi?id=247460 rdar://101934826 Reviewed by Dewei Zhu. Fix for JS2 tests in `jsc` shell (and also RAMification) being broken due to https://bugs.webkit.org/show_bug.cgi?id=247301 `URLSearchParams` is undefined in the `jsc` shell. But when run in the shell, URL parameters are irrelevant anyways so ideally they should be ignored. - Set default values for whether to report test results (false) and which specific subtests to run (empty list, or run all tests by default). - Check if `URLSearchParams` is defined, and if it is, override default reporting/subtest values with the ones specified. * PerformanceTests/JetStream2/JetStreamDriver.js: (typeof): (Driver.prototype.async initialize): (Driver.prototype.async reportScoreToRunBenchmarkRunner): (prototype.else): * PerformanceTests/JetStream3/JetStreamDriver.js: (typeof): (Driver.prototype.async initialize): (Driver.prototype.async reportScoreToRunBenchmarkRunner): (prototype.else): Canonical link: https://commits.webkit.org/256304@main
|
Committed 256304@main (e43d0d6): https://commits.webkit.org/256304@main Reviewed commits have been landed. Closing PR #6109 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
|
thanks @xw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e43d0d6
c164c98
🛠 mac🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress