[WK2][GLib] Clean up GLib ArgumentCoders specializations #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdobersek
added
New Bugs
|
EWS run on current version of this PR (hash 330545c)
|
carlosgcampos
approved these changes
Nov 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=247561 Reviewed by Carlos Garcia Campos. In ArgumentCoder specializations for GVariant and GTlsCertificate objects managed through GRefPtrs, have the encode methods accept simple references to the GRefPtrs, avoiding unnecessary refcounting churn. Drop the encoder and decoder type templates on the GTlsCertificate specialization of ArgumentCoder and subsequently-necessary specializations for the IPC::Encoder and IPC::Decoder methods. We can enforce those two types without the template, and support for other encoders and decoders likely won't be necessary. * Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp: (IPC::ArgumentCoder<GRefPtr<GVariant>>::encode): (IPC::ArgumentCoder<GRefPtr<GTlsCertificate>>::encode): (IPC::ArgumentCoder<GRefPtr<GTlsCertificate>>::decode): * Source/WebKit/Shared/glib/ArgumentCodersGLib.h: Canonical link: https://commits.webkit.org/256389@main
webkit-early-warning-system
force-pushed
the
eng/WK2GLib-Clean-up-GLib-ArgumentCoders-specializations
branch
from
330545c
to
b842b37
Compare
|
Committed 256389@main (b842b37): https://commits.webkit.org/256389@main Reviewed commits have been landed. Closing PR #6198 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b842b37
330545c
🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2