-webkit-radial-gradient parsing accidentally treats a number of mandatory commas as optional #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 5bcb92c)
|
weinig
approved these changes
Nov 8, 2022
darinadler
added
merge-queue
…tory commas as optional https://bugs.webkit.org/show_bug.cgi?id=247649 rdar://problem/102111231 Reviewed by Sam Weinig. * LayoutTests/imported/w3c/web-platform-tests/compat/webkit-gradient-comma-expected.txt: Expect PASS. * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePrefixedRadialGradient): Rearranged the comma parsing so it matches the grammar, and fail if the commas are missing. Canonical link: https://commits.webkit.org/256468@main
webkit-commit-queue
force-pushed
the
eng/-webkit-radial-gradient-parsing-accidentally-treats-a-number-of-mandatory-commas-as-optional
branch
from
5bcb92c
to
a62f777
Compare
|
Committed 256468@main (a62f777): https://commits.webkit.org/256468@main Reviewed commits have been landed. Closing PR #6270 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
darinadler
deleted the
eng/-webkit-radial-gradient-parsing-accidentally-treats-a-number-of-mandatory-commas-as-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a62f777
5bcb92c
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2