Prevent hidden documents from locking the screen orientation #6283

marcoscaceres · 2022-11-09T04:56:13Z

`a68ef76`

Prevent hidden documents from locking the screen orientation
https://bugs.webkit.org/show_bug.cgi?id=247248
rdar://102019707

Reviewed by Youenn Fablet.

* LayoutTests/fast/screen-orientation/hidden-document-check-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:
(window.test_driver_internal.action_sequence):
(async if):
(window.test_driver_internal.minimize_window):
(window.test_driver_internal.set_window_rect):
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):

Canonical link: https://commits.webkit.org/257019@main

c7728e5

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-09T04:58:52Z

EWS run on previous version of this PR (hash f065b9c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	~~🛠 gtk~~	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🛠 mac-AS-debug~~	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	~~🛠 watch~~	~~🧪 mac-AS-debug-wk2~~
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-09T05:07:19Z

EWS run on previous version of this PR (hash aa52579)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

marcoscaceres · 2022-11-10T03:30:08Z

That mac-wk1 failure is a bit odd:

PASS SecurityError rejected promise  with InvalidStateError: No browsing context.

@hortont424, would the lack of a browsing context be a wk1 thing (even thought the script is running in page)? Any suggestions?

webkit-early-warning-system · 2022-11-14T05:08:59Z

EWS run on previous version of this PR (hash 3f9f188)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Source/WebCore/page/ScreenOrientation.cpp

youennf · 2022-11-14T07:08:42Z

Source/WebCore/page/ScreenOrientation.cpp

+        promise->reject(Exception { SecurityError, "Only visible documents can lock the screen orientation"_s });
+        return;
+    }
+


Unrelated to this patch, but we could try to use DOMPromiseDeferred::settle in manager->lock().
Maybe by adding settle(std::optional) to it?

youennf · 2022-11-14T07:09:48Z

LayoutTests/TestExpectations

@@ -6041,3 +6041,7 @@ http/tests/loading/oauth.html [ DumpJSConsoleLogInStdErr ]
 http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/html/infrastructure/urls/terminology-0/document-base-url-initiated-grand-parent.https.window.html [ DumpJSConsoleLogInStdErr ]
+
+# Screen orientation
+## We don't implment test_driver.minimize_window()


Is window.internals.setPageVisibility good enough to implement test_driver.minimize_window?
If so, could we try implementing it this way?

I had a look. We might be able to use the same semantics ((ab)using page visibility), but I don't think we can use window.internal, as it needs to be done through TestDriver.

Is my understanding correct?

Can we update LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js to use window.internals?

Indeed we can, I recently discovered. 🎉 I’ll patch something up.

LayoutTests/fast/screen-orientation/hidden-document-check.html

webkit-early-warning-system · 2022-11-24T05:09:35Z

EWS run on previous version of this PR (hash 92adf27)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-11-24T05:24:26Z

EWS run on previous version of this PR (hash f5d053f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
	⏳ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-11-24T05:33:38Z

Starting EWS tests for 262d5ec. Live statuses available at the PR page, #6283

webkit-early-warning-system · 2022-11-24T05:33:39Z

EWS run on previous version of this PR (hash 262d5ec)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 🧪 win~~
~~🧪 bindings~~	✅ 🛠 ios-sim	~~🛠 mac-debug~~	~~🛠 gtk~~	~~🛠 wincairo~~
~~🧪 webkitperl~~	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	~~🛠 tv~~	~~🧪 mac-wk1~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2~~
	~~🛠 watch~~	⏳ 🧪 mac-AS-debug-wk2
	~~🛠 watch-sim~~	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-11-24T05:33:41Z

EWS run on previous version of this PR (hash 11758f8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js

LayoutTests/fast/screen-orientation/hidden-document-check.html

webkit-early-warning-system · 2022-11-24T08:40:09Z

EWS run on previous version of this PR (hash aae8614)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	~~🧪 api-mac~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	~~🧪 mac-wk1~~
	⏳ 🛠 tv-sim	~~🧪 mac-wk2~~
	⏳ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-11-24T08:53:06Z

EWS run on previous version of this PR (hash 389781b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-24T23:58:38Z

EWS run on current version of this PR (hash c7728e5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=247248 rdar://102019707 Reviewed by Youenn Fablet. * LayoutTests/fast/screen-orientation/hidden-document-check-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js: (window.test_driver_internal.action_sequence): (async if): (window.test_driver_internal.minimize_window): (window.test_driver_internal.set_window_rect): * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html: Added. * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/page/ScreenOrientation.cpp: (WebCore::ScreenOrientation::lock): Canonical link: https://commits.webkit.org/257019@main

webkit-commit-queue · 2022-11-25T11:22:53Z

Committed 257019@main (a68ef76): https://commits.webkit.org/257019@main

Reviewed commits have been landed. Closing PR #6283 and removing active labels.

marcoscaceres self-assigned this Nov 9, 2022

marcoscaceres added Other WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). labels Nov 9, 2022

marcoscaceres mentioned this pull request Nov 9, 2022

Prevent hidden documents from locking orientation w3c/screen-orientation#232

Merged

4 tasks

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 14, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 14, 2022

youennf approved these changes Nov 14, 2022

View reviewed changes

xeenon removed the Other label Nov 21, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022

marcoscaceres marked this pull request as ready for review November 24, 2022 05:24

marcoscaceres requested a review from cdumez as a code owner November 24, 2022 05:24

marcoscaceres requested a review from youennf November 24, 2022 05:24

nt1m reviewed Nov 24, 2022

View reviewed changes

LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022

youennf approved these changes Nov 24, 2022

View reviewed changes

LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js Outdated Show resolved Hide resolved

LayoutTests/fast/screen-orientation/hidden-document-check.html Outdated Show resolved Hide resolved

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 25, 2022

marcoscaceres added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 25, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 25, 2022

webkit-early-warning-system merged commit a68ef76 into WebKit:main Nov 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent hidden documents from locking the screen orientation #6283

Prevent hidden documents from locking the screen orientation #6283

marcoscaceres commented Nov 9, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 9, 2022 •

edited

webkit-early-warning-system commented Nov 9, 2022 •

edited

marcoscaceres commented Nov 10, 2022

webkit-early-warning-system commented Nov 14, 2022 •

edited

youennf Nov 14, 2022

youennf Nov 14, 2022

marcoscaceres Nov 15, 2022

youennf Nov 16, 2022

marcoscaceres Nov 18, 2022

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-commit-queue commented Nov 25, 2022

Prevent hidden documents from locking the screen orientation #6283

Prevent hidden documents from locking the screen orientation #6283

Conversation

marcoscaceres commented Nov 9, 2022 • edited by webkit-early-warning-system

a68ef76

webkit-early-warning-system commented Nov 9, 2022 • edited

webkit-early-warning-system commented Nov 9, 2022 • edited

marcoscaceres commented Nov 10, 2022

webkit-early-warning-system commented Nov 14, 2022 • edited

youennf Nov 14, 2022

Choose a reason for hiding this comment

youennf Nov 14, 2022

Choose a reason for hiding this comment

marcoscaceres Nov 15, 2022

Choose a reason for hiding this comment

youennf Nov 16, 2022

Choose a reason for hiding this comment

marcoscaceres Nov 18, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-early-warning-system commented Nov 24, 2022 • edited

webkit-commit-queue commented Nov 25, 2022

marcoscaceres commented Nov 9, 2022 •

edited by webkit-early-warning-system

`a68ef76`

webkit-early-warning-system commented Nov 9, 2022 •

edited

webkit-early-warning-system commented Nov 9, 2022 •

edited

webkit-early-warning-system commented Nov 14, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited

webkit-early-warning-system commented Nov 24, 2022 •

edited