New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LBSE] Add remaining compositing tests from LBSE downstream #6291
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nikolaszimmermann:eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream
Nov 9, 2022
Merged
[LBSE] Add remaining compositing tests from LBSE downstream #6291
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
nikolaszimmermann:eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikolaszimmermann
added
SVG
For bugs in the SVG implementation.
WebKit Local Build
labels
Nov 9, 2022
EWS run on current version of this PR (hash 1a70155) |
rwlbuis
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if all turns out green).
nikolaszimmermann
added
the
merge-queue
Applied to send a pull request to merge-queue
label
Nov 9, 2022
https://bugs.webkit.org/show_bug.cgi?id=247667 Reviewed by Rob Buis. Upstream remaining compositing tests - most of them are basic and helped brining up compositing in LBSE. All tests pass in LBSE already. No change in functionality, only adding new tests. * LayoutTests/svg/compositing/container-after-composited-child-expected.svg: Added. * LayoutTests/svg/compositing/container-after-composited-child.svg: Added. * LayoutTests/svg/compositing/container-before-composited-child-expected.svg: Added. * LayoutTests/svg/compositing/container-before-composited-child.svg: Added. * LayoutTests/svg/compositing/outermost-svg-directly-composited-group-child-overflow-hidden.html: * LayoutTests/svg/compositing/rect-as-container-child-1-expected.svg: Added. * LayoutTests/svg/compositing/rect-as-container-child-1.svg: Added. * LayoutTests/svg/compositing/rect-as-container-child-2-expected.svg: Added. * LayoutTests/svg/compositing/rect-as-container-child-2.svg: Added. * LayoutTests/svg/compositing/rect-as-container-child-3-expected.svg: Added. * LayoutTests/svg/compositing/rect-as-container-child-3.svg: Added. * LayoutTests/svg/compositing/rect-as-transformed-container-child-expected.svg: Added. * LayoutTests/svg/compositing/rect-as-transformed-container-child.svg: Added. * LayoutTests/svg/compositing/rect-direct-svg-root-child-expected.svg: Added. * LayoutTests/svg/compositing/rect-direct-svg-root-child.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-1-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-1.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-2-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-2.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-3-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-3.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-4-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-4.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-5-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-5.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-6-expected.svg: Added. * LayoutTests/svg/compositing/rect-in-nested-transformed-container-6.svg: Added. * LayoutTests/svg/compositing/transformed-container-after-composited-child-expected.svg: Added. * LayoutTests/svg/compositing/transformed-container-after-composited-child.svg: Added. * LayoutTests/svg/compositing/transformed-container-before-composited-child-expected.svg: Added. * LayoutTests/svg/compositing/transformed-container-before-composited-child.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-container-child-expected.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-container-child.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1-expected.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2-expected.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3-expected.svg: Added. * LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3.svg: Added. * LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child-expected.svg: Added. * LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child.svg: Added. Canonical link: https://commits.webkit.org/256502@main
webkit-early-warning-system
force-pushed
the
eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream
branch
from
November 9, 2022 22:34
1a70155
to
69d1edc
Compare
Committed 256502@main (69d1edc): https://commits.webkit.org/256502@main Reviewed commits have been landed. Closing PR #6291 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Nov 9, 2022
nikolaszimmermann
deleted the
eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream
branch
November 10, 2022 10:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
69d1edc
1a70155
π§ͺ api-iosπ§ͺ mac-wk1