Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LBSE] Add remaining compositing tests from LBSE downstream #6291

Conversation

nikolaszimmermann
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann commented Nov 9, 2022

69d1edc

[LBSE] Add remaining compositing tests from LBSE downstream
https://bugs.webkit.org/show_bug.cgi?id=247667

Reviewed by Rob Buis.

Upstream remaining compositing tests - most of them are basic and helped
brining up compositing in LBSE. All tests pass in LBSE already.

No change in functionality, only adding new tests.

* LayoutTests/svg/compositing/container-after-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/container-after-composited-child.svg: Added.
* LayoutTests/svg/compositing/container-before-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/container-before-composited-child.svg: Added.
* LayoutTests/svg/compositing/outermost-svg-directly-composited-group-child-overflow-hidden.html:
* LayoutTests/svg/compositing/rect-as-container-child-1-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-1.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-2-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-2.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-3-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-3.svg: Added.
* LayoutTests/svg/compositing/rect-as-transformed-container-child-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-transformed-container-child.svg: Added.
* LayoutTests/svg/compositing/rect-direct-svg-root-child-expected.svg: Added.
* LayoutTests/svg/compositing/rect-direct-svg-root-child.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-1-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-1.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-2-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-2.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-3-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-3.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-4-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-4.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-5-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-5.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-6-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-6.svg: Added.
* LayoutTests/svg/compositing/transformed-container-after-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-container-after-composited-child.svg: Added.
* LayoutTests/svg/compositing/transformed-container-before-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-container-before-composited-child.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-container-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-container-child.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child.svg: Added.

Canonical link: https://commits.webkit.org/256502@main

1a70155

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@nikolaszimmermann nikolaszimmermann self-assigned this Nov 9, 2022
@nikolaszimmermann nikolaszimmermann added SVG For bugs in the SVG implementation. WebKit Local Build labels Nov 9, 2022
Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if all turns out green).

@nikolaszimmermann nikolaszimmermann added the merge-queue Applied to send a pull request to merge-queue label Nov 9, 2022
https://bugs.webkit.org/show_bug.cgi?id=247667

Reviewed by Rob Buis.

Upstream remaining compositing tests - most of them are basic and helped
brining up compositing in LBSE. All tests pass in LBSE already.

No change in functionality, only adding new tests.

* LayoutTests/svg/compositing/container-after-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/container-after-composited-child.svg: Added.
* LayoutTests/svg/compositing/container-before-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/container-before-composited-child.svg: Added.
* LayoutTests/svg/compositing/outermost-svg-directly-composited-group-child-overflow-hidden.html:
* LayoutTests/svg/compositing/rect-as-container-child-1-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-1.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-2-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-2.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-3-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-container-child-3.svg: Added.
* LayoutTests/svg/compositing/rect-as-transformed-container-child-expected.svg: Added.
* LayoutTests/svg/compositing/rect-as-transformed-container-child.svg: Added.
* LayoutTests/svg/compositing/rect-direct-svg-root-child-expected.svg: Added.
* LayoutTests/svg/compositing/rect-direct-svg-root-child.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-1-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-1.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-2-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-2.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-3-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-3.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-4-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-4.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-5-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-5.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-6-expected.svg: Added.
* LayoutTests/svg/compositing/rect-in-nested-transformed-container-6.svg: Added.
* LayoutTests/svg/compositing/transformed-container-after-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-container-after-composited-child.svg: Added.
* LayoutTests/svg/compositing/transformed-container-before-composited-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-container-before-composited-child.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-container-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-container-child.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-1.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-2.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-as-transformed-container-child-3.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child-expected.svg: Added.
* LayoutTests/svg/compositing/transformed-rect-direct-svg-root-child.svg: Added.

Canonical link: https://commits.webkit.org/256502@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream branch from 1a70155 to 69d1edc Compare November 9, 2022 22:34
@webkit-commit-queue
Copy link
Collaborator

Committed 256502@main (69d1edc): https://commits.webkit.org/256502@main

Reviewed commits have been landed. Closing PR #6291 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 69d1edc into WebKit:main Nov 9, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 9, 2022
@nikolaszimmermann nikolaszimmermann deleted the eng/LBSE-Add-remaining-compositing-tests-from-LBSE-downstream branch November 10, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SVG For bugs in the SVG implementation.
Projects
None yet
4 participants