New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font-variant-alternates list support and case-insensitivity #6299
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
mdubet:font-variant-alternates-list-support
Nov 15, 2022
Merged
font-variant-alternates list support and case-insensitivity #6299
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
mdubet:font-variant-alternates-list-support
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubet
added
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
WebKit Nightly Build
labels
Nov 9, 2022
EWS run on previous version of this PR (hash 185980c) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 9, 2022
mdubet
force-pushed
the
font-variant-alternates-list-support
branch
from
November 9, 2022 17:31
185980c
to
c78a033
Compare
EWS run on previous version of this PR (hash c78a033) |
darinadler
approved these changes
Nov 12, 2022
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 14, 2022
mdubet
changed the title
Support list for CSS feature-variant-alternates
font-variant-alternates list support and case-insensitivity
Nov 14, 2022
mdubet
force-pushed
the
font-variant-alternates-list-support
branch
from
November 14, 2022 16:28
c78a033
to
4f85275
Compare
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 14, 2022
nt1m
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
merge-queue
Applied to send a pull request to merge-queue
labels
Nov 15, 2022
https://bugs.webkit.org/show_bug.cgi?id=246811 rdar://101638181 https://www.w3.org/TR/css-fonts-4/#font-variant-alternates-prop CSS "character-variant" and "styleset" support a list of feature names in CSS. Before this patch, only a single feature name was supported. This patch also contains a change to make font family name matching case insensitive for "@font-feature-values" at-rule. Reviewed by Darin Adler. * LayoutTests/TestExpectations: The alternates-order.html layout test contains 9 specific tests related to font variant. This patch fixes the remaining 2 out of 9 which were failing: - one because of the case-sensitivity in font name matching. - another because of the missing support for list value. * LayoutTests/platform/gtk/TestExpectations: * Source/WTF/wtf/text/WTFString.cpp: (WTF::makeStringByJoining): * Source/WTF/wtf/text/WTFString.h: * Source/WebCore/css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFeatureValuesRule): (WebCore::CSSFontSelector::lookupFontFeatureValues): * Source/WebCore/css/CSSFontSelector.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontVariantAlternates): * Source/WebCore/platform/text/TextFlags.cpp: (WebCore::operator<<): (WebCore::computeFeatureSettingsFromVariants): * Source/WebCore/platform/text/TextFlags.h: * Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/256702@main
webkit-early-warning-system
force-pushed
the
font-variant-alternates-list-support
branch
from
November 15, 2022 18:16
4f85275
to
fd6f66d
Compare
Committed 256702@main (fd6f66d): https://commits.webkit.org/256702@main Reviewed commits have been landed. Closing PR #6299 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd6f66d
4f85275
π π§ͺ merge