Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly mark the background content as non-persistent, so we don't emit a parsing error on iOS. #6310

Merged
merged 1 commit into from Nov 10, 2022
Merged

Explicitly mark the background content as non-persistent, so we don't emit a parsing error on iOS. #6310

merged 1 commit into from Nov 10, 2022

Conversation

eepskamp
Copy link

@eepskamp eepskamp commented Nov 9, 2022 •
edited by webkit-early-warning-system

572be02

Explicitly mark the background content as non-persistent, so we don't emit a parsing error on iOS.
https://bugs.webkit.org/show_bug.cgi?id=247656
rdar://102116163

Reviewed by Timothy Hatcher.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/256546@main

f51ac4f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv 💥 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f51ac4f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv 💥 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@eepskamp
Copy link
Author

"worker/0 TestWebKitAPI.WKWebExtension.BackgroundParsing Passed"
From the api-iOS run.

kiaraarose
kiaraarose reviewed Nov 10, 2022
View reviewed changes
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
@@ -594,14 +594,14 @@
EXPECT_NOT_NULL(matchingError(testExtension.errors, _WKWebExtensionErrorInvalidManifestEntry));
EXPECT_NULL(matchingError(testExtension.errors, _WKWebExtensionErrorInvalidBackgroundPersistence));

testManifestDictionary[@"background"] = @{ @"service_worker": @"test.js", @"type": @"module" };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add comments to express what these test cases are for?

@xeenon
Copy link
Contributor

xeenon commented Nov 10, 2022

This is likely the same reason WKWebExtensionController.mm has failures!

@xeenon xeenon added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2022
@xeenon
Explicitly mark the background content as non-persistent, so we don't…
572be02 
… emit a parsing error on iOS.

https://bugs.webkit.org/show_bug.cgi?id=247656
rdar://102116163

Reviewed by Timothy Hatcher.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/256546@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-256257main-iOS-TestWebKitAPI-WKWebExtension-BackgroundParsing-is-consistently-failing branch from f51ac4f to 572be02 Compare November 10, 2022 21:25
@webkit-commit-queue
Copy link
Collaborator

Committed 256546@main (572be02): https://commits.webkit.org/256546@main

Reviewed commits have been landed. Closing PR #6310 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 572be02 into WebKit:main Nov 10, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2022
@xeenon xeenon added the WebKit Extensions Bugs related to extension support. label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaraarose kiaraarose kiaraarose left review comments

@xeenon xeenon xeenon approved these changes

@b-weinstein b-weinstein Awaiting requested review from b-weinstein b-weinstein is a code owner

Assignees
No one assigned
Labels
WebKit Extensions Bugs related to extension support.
Projects
None yet
Milestone
No milestone
5 participants
@eepskamp @webkit-early-warning-system @xeenon @webkit-commit-queue @kiaraarose