Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK4] Disable threaded rendering by default #6337

Conversation

@carlosgcampos carlosgcampos self-assigned this Nov 10, 2022
@carlosgcampos carlosgcampos added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels Nov 10, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022
@carlosgcampos carlosgcampos removed the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022
@carlosgcampos carlosgcampos added the merge-queue Applied to send a pull request to merge-queue label Nov 10, 2022
https://bugs.webkit.org/show_bug.cgi?id=247719

Reviewed by Miguel Gomez.

Cairo is not thread safe and threaded rendering is causing some crashes
when building with GTK4.

* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
(Nicosia::PaintingEngine::create):

Canonical link: https://commits.webkit.org/256526@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GTK4-Disable-threaded-rendering-by-default branch from 56ceba2 to b97318e Compare November 10, 2022 10:34
@webkit-commit-queue
Copy link
Collaborator

Committed 256526@main (b97318e): https://commits.webkit.org/256526@main

Reviewed commits have been landed. Closing PR #6337 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit b97318e into WebKit:main Nov 10, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 10, 2022
@carlosgcampos carlosgcampos deleted the eng/GTK4-Disable-threaded-rendering-by-default branch November 10, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
5 participants