Setting -webkit-column-count to auto is the same as not setting it

[Ahmad-S792]

bc1d076

Setting -webkit-column-count to auto is the same as not setting it

Setting -webkit-column-count to auto is the same as not setting it
https://bugs.webkit.org/show_bug.cgi?id=247745

Reviewed by Alan Baradlay.

Merge - https://chromium.googlesource.com/chromium/blink/+/da85d1a90375fe50a92cf46f8a49571850618294

In RenderStyle, column-count is represented by two members, one integer
specifying the count, and one bool specifying whether it's auto or not. If
column-count is auto, the integer is ignored, but if the integer changes, it's
still detected as a style change (even if auto is set to true), and we'll mark
for layout for no good reason. Make sure that setting column-count to auto also
resets the integer to its initial value, to avoid this problem.

* Source/WebCore/rendering/style/RenderStyle.h: Update "setHasAutoColumnCount" to return "initialColumnCount" rather than "0"

Canonical link: https://commits.webkit.org/256607@main

67baed6

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 94309fc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🛠 mac-AS-debug	🧪 gtk-wk2
	✅ 🧪 api-ios	🧪 api-mac	🧪 api-gtk
	✅ 🛠 tv	🧪 mac-wk1
	✅ 🛠 tv-sim	🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	🧪 mac-wk2-stress

[Ahmad-S792]

I have to close this bug because Webkit does not support "-webkit-columns: auto " properly and also don't have related Internals Webkit Testing Framework API to land this as it is. I have added first parsing bug as "See Also" while also explained the internal testing framework thing on the bug for future reference. Closing this now.

[alanbaradlay]

I'd just land this patch without the test case.

[Ahmad-S792]

I'd just land this patch without the test case.

Perfect! I will update it and remove test cases and will push it for your review. Thanks!

[webkit-early-warning-system]

EWS run on current version of this PR (hash 67baed6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[Ahmad-S792]

@alanbaradlay - Pushed new build without test cases. Appreciate if you can review. Thanks!

[Ahmad-S792]

The test failure is related to Service Worker and with same patch previous run was fine and it didn't had any such failure, so IMO something in the tree failed leading to these issues. Further, it passed all tests except the introduced one, so I am going to merge this.

[webkit-commit-queue]

Committed 256607@main (bc1d076): https://commits.webkit.org/256607@main

Reviewed commits have been landed. Closing PR #6368 and removing active labels.