[SVG] Escape non-ASCII characters in console messages #6402

Ahmad-S792 · 2022-11-11T18:09:24Z

[SVG] Escape non-ASCII characters in console messages
https://bugs.webkit.org/show_bug.cgi?id=247814

Reviewed by NOBODY (OOPS!).

Merge - https://chromium.googlesource.com/chromium/blink/+/a2db82039c609e1aac58a17e660aa10235331d23

This is to align with Blink / Chrome behavior to allow escape non-ASCII characters in console messages.

* Source/WebCore/svg/SVGElement.cpp: Add "JSONValues.h" header
(SVGElement::reportAttributeParsingError): Update errorString to escape non-ASCII characters

516f408

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-11T18:10:06Z

EWS run on previous version of this PR (hash 7fbe7c8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-11T18:24:38Z

EWS run on previous version of this PR (hash b1764d5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	~~🛠 ios-sim~~	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🛠 mac-AS-debug~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	❌ 🛠 tv	⏳ 🧪 mac-wk1
	❌ 🛠 tv-sim	⏳ 🧪 mac-wk2
	~~🛠 watch~~	~~🧪 mac-AS-debug-wk2~~
	❌ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-11T18:36:07Z

EWS run on previous version of this PR (hash efd2f54)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	❌ 🛠 🧪 win
✅ 🧪 bindings	~~🛠 ios-sim~~	~~🛠 mac-debug~~	~~🛠 gtk~~	~~🛠 wincairo~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	❌ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 api-mac~~	~~🧪 api-gtk~~
	❌ 🛠 tv	~~🧪 mac-wk1~~
	❌ 🛠 tv-sim	~~🧪 mac-wk2~~
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	~~🛠 watch-sim~~	~~🧪 mac-wk2-stress~~

shallawa · 2022-11-18T18:37:56Z

Source/WebCore/svg/SVGElement.cpp

@@ -243,7 +244,7 @@ void SVGElement::reportAttributeParsingError(SVGParsingError error, const Qualif
    if (error == NoError)
        return;

-    String errorString = "<" + tagName() + "> attribute " + name.toString() + "=\"" + value + "\"";
+    String errorString = "<" + tagName() + "> attribute " + name.toString() + "=" + JSON::Value::escapeString(value);


You can add this static function to JSON::Value and it will make things compile:

String Value::escapeString(StringView string) { StringBuilder result; escapeString(result, string); return result.toString(); }

Sure, I will reopen and push an update.

I tried but it didn't work and then I tried to look into Chromium implementation and trying to see if it works but I think it would be difficult. My local build environment is also not working.

webkit-early-warning-system · 2022-11-18T18:59:19Z

EWS run on current version of this PR (hash efd2f54)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
~~🧪 webkitperl~~	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
⏳ 🧪 webkitpy	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T18:59:21Z

EWS run on previous version of this PR (hash 00e7ebe)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T18:59:26Z

EWS run on previous version of this PR (hash 00e7ebe)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T22:00:06Z

EWS run on previous version of this PR (hash ed1fec9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T22:01:47Z

EWS run on previous version of this PR (hash ed1fec9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T23:50:17Z

EWS run on previous version of this PR (hash 1300eee)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T23:52:36Z

EWS run on previous version of this PR (hash 1300eee)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T00:09:44Z

EWS run on previous version of this PR (hash 5199094)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T00:13:34Z

EWS run on previous version of this PR (hash 5199094)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T00:51:07Z

EWS run on previous version of this PR (hash 48f3dcc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T00:54:51Z

EWS run on previous version of this PR (hash 48f3dcc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T01:00:47Z

EWS run on previous version of this PR (hash 55ed06d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T01:03:03Z

EWS run on previous version of this PR (hash 55ed06d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	⏳ 🧪 api-gtk
❌ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T01:18:31Z

EWS run on previous version of this PR (hash 517f5dc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T01:20:23Z

EWS run on previous version of this PR (hash 517f5dc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	~~🛠 mac-debug~~	~~🛠 gtk~~	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 api-mac	~~🧪 api-gtk~~
❌ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

[SVG] Escape non-ASCII characters in console messages https://bugs.webkit.org/show_bug.cgi?id=247814 Reviewed by NOBODY (OOPS!). Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=196815 This is to align with Blink / Chrome behavior to allow escape non-ASCII characters in console messages. * Source/WebCore/svg/SVGElement.cpp: Add "JSONValues.h" header (SVGElement::reportAttributeParsingError): Update errorString to escape non-ASCII characters * Source/WTF/wtf/JSONValue.cpp: Add "quoteString" function * Source/WTF/wtf/JSONValues.h: Add definition for 'quoteString'

webkit-early-warning-system · 2022-11-19T01:37:08Z

EWS run on current version of this PR (hash 516f408)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T01:37:14Z

EWS run on current version of this PR (hash 516f408)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 11, 2022

Ahmad-S792 force-pushed the fix247814 branch from 7fbe7c8 to b1764d5 Compare November 11, 2022 18:23

Ahmad-S792 force-pushed the fix247814 branch from b1764d5 to efd2f54 Compare November 11, 2022 18:34

Ahmad-S792 closed this Nov 11, 2022

shallawa reviewed Nov 18, 2022

View reviewed changes

Ahmad-S792 reopened this Nov 18, 2022

Ahmad-S792 force-pushed the fix247814 branch from efd2f54 to 00e7ebe Compare November 18, 2022 18:59

Ahmad-S792 force-pushed the fix247814 branch from 00e7ebe to ed1fec9 Compare November 18, 2022 21:59

Ahmad-S792 force-pushed the fix247814 branch from ed1fec9 to 1300eee Compare November 18, 2022 23:49

Ahmad-S792 force-pushed the fix247814 branch from 1300eee to 5199094 Compare November 19, 2022 00:09

Ahmad-S792 force-pushed the fix247814 branch from 5199094 to 48f3dcc Compare November 19, 2022 00:51

Ahmad-S792 force-pushed the fix247814 branch from 48f3dcc to 55ed06d Compare November 19, 2022 01:00

Ahmad-S792 force-pushed the fix247814 branch from 55ed06d to 517f5dc Compare November 19, 2022 01:17

Ahmad-S792 force-pushed the fix247814 branch from 517f5dc to 516f408 Compare November 19, 2022 01:36

Ahmad-S792 closed this Dec 12, 2022

Ahmad-S792 deleted the fix247814 branch October 2, 2023 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SVG] Escape non-ASCII characters in console messages #6402

[SVG] Escape non-ASCII characters in console messages #6402

Ahmad-S792 commented Nov 11, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 11, 2022 •

edited

webkit-early-warning-system commented Nov 11, 2022 •

edited

webkit-early-warning-system commented Nov 11, 2022 •

edited

shallawa Nov 18, 2022

Ahmad-S792 Nov 18, 2022

Ahmad-S792 Nov 19, 2022

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

[SVG] Escape non-ASCII characters in console messages #6402

[SVG] Escape non-ASCII characters in console messages #6402

Conversation

Ahmad-S792 commented Nov 11, 2022 • edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 11, 2022 • edited

webkit-early-warning-system commented Nov 11, 2022 • edited

webkit-early-warning-system commented Nov 11, 2022 • edited

shallawa Nov 18, 2022

Choose a reason for hiding this comment

Ahmad-S792 Nov 18, 2022

Choose a reason for hiding this comment

Ahmad-S792 Nov 19, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 18, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

webkit-early-warning-system commented Nov 19, 2022 • edited

Ahmad-S792 commented Nov 11, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 11, 2022 •

edited

webkit-early-warning-system commented Nov 11, 2022 •

edited

webkit-early-warning-system commented Nov 11, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 18, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited

webkit-early-warning-system commented Nov 19, 2022 •

edited