Remove unneeded and unused UserData parameter in navigation client callbacks #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
WebKit API
|
EWS run on previous version of this PR (hash fef97d5)
|
webkit-ews-buildbot
added
the
merging-blocked
achristensen07
force-pushed
the
eng/Remove-unneeded-and-unused-UserData-parameter-in-navigation-client-callbacks
branch
from
fef97d5
to
be80e27
Compare
|
EWS run on previous version of this PR (hash be80e27)
|
hortont424
reviewed
Nov 11, 2022
| @@ -1314,10 +1314,13 @@ void WKPageSetPagePolicyClient(WKPageRef pageRef, const WKPagePolicyClientBase* | |||
| explicit PolicyClient(const WKPagePolicyClientBase* client) | |||
| { | |||
| initialize(client); | |||
|
|
|||
| // This callback is unused and deprecated. | |||
| RELEASE_ASSERT(!m_client.unableToImplementPolicy); | |||
There was a problem hiding this comment.
This seems a bit aggressive.
There was a problem hiding this comment.
This is done elsewhere in this file to ensure that if someone is using that SPI, we will notice instead of just having silent failures that are hard to notice.
hortont424
approved these changes
Nov 11, 2022
achristensen07
added
unsafe-merge-queue
achristensen07
force-pushed
the
eng/Remove-unneeded-and-unused-UserData-parameter-in-navigation-client-callbacks
branch
from
be80e27
to
acc25bd
Compare
|
EWS run on current version of this PR (hash acc25bd)
|
achristensen07
added
merge-queue
…llbacks https://bugs.webkit.org/show_bug.cgi?id=247816 Reviewed by Tim Horton. * Source/WebKit/UIProcess/API/APINavigationClient.h: (API::NavigationClient::decidePolicyForNavigationAction): (API::NavigationClient::decidePolicyForNavigationResponse): * Source/WebKit/UIProcess/API/APIPolicyClient.h: (API::PolicyClient::decidePolicyForNavigationAction): (API::PolicyClient::decidePolicyForNewWindowAction): (API::PolicyClient::decidePolicyForResponse): (API::PolicyClient::unableToImplementPolicy): Deleted. * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPagePolicyClient): (WKPageSetPageNavigationClient): * Source/WebKit/UIProcess/Cocoa/NavigationState.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse): * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): (WebKit::ProvisionalPageProxy::decidePolicyForResponse): (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::decidePolicyForResponseShared): (WebKit::WebPageProxy::unableToImplementPolicy): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): Canonical link: https://commits.webkit.org/256598@main
webkit-early-warning-system
force-pushed
the
eng/Remove-unneeded-and-unused-UserData-parameter-in-navigation-client-callbacks
branch
from
acc25bd
to
81e1905
Compare
|
Committed 256598@main (81e1905): https://commits.webkit.org/256598@main Reviewed commits have been landed. Closing PR #6404 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
81e1905
acc25bd
🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2