Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form associated behavior for option.form when it is select on "select" element parent #6423

Merged
merged 1 commit into from Nov 12, 2022
Merged

Fix form associated behavior for option.form when it is select on "select" element parent #6423

merged 1 commit into from Nov 12, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Nov 12, 2022 •
edited by webkit-early-warning-system

9d95887

Fix form associated behavior for option.form when it is select on "select" element parent
https://bugs.webkit.org/show_bug.cgi?id=247651

Reviewed by Wenson Hsieh.

Make HTMLOptionElement's form IDL attribute return null when it's not associated with a select element.
New behavior matches the specification and the behaviors of Firefox and Chrome.

Spec: https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-form

* LayoutTests/fast/forms/option-form-expected.txt: Added.
* LayoutTests/fast/forms/option-form.html: Added.
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::form const):
* Source/WebCore/html/HTMLOptionElement.h:

Canonical link: https://commits.webkit.org/256612@main

a0835d9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa requested a review from cdumez as a code owner November 12, 2022 08:50
@rniwa rniwa self-assigned this Nov 12, 2022
@rniwa rniwa added Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) WebKit Nightly Build labels Nov 12, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 1afd9f0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim   🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a0835d9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 12, 2022
@rniwa
Fix form associated behavior for option.form when it is select on "se…
9d95887 
…lect" element parent

https://bugs.webkit.org/show_bug.cgi?id=247651

Reviewed by Wenson Hsieh.

Make HTMLOptionElement's form IDL attribute return null when it's not associated with a select element.
New behavior matches the specification and the behaviors of Firefox and Chrome.

Spec: https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-form

* LayoutTests/fast/forms/option-form-expected.txt: Added.
* LayoutTests/fast/forms/option-form.html: Added.
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::form const):
* Source/WebCore/html/HTMLOptionElement.h:

Canonical link: https://commits.webkit.org/256612@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256612@main (9d95887): https://commits.webkit.org/256612@main

Reviewed commits have been landed. Closing PR #6423 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 9d95887 into WebKit:main Nov 12, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 12, 2022
@rniwa rniwa deleted the fix247651 branch November 12, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@rniwa rniwa

Labels
Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @whsieh