Address FIXMEs in process-css-properties.py #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinig
changed the title
weinig
force-pushed
the
eng/Address-FIXMEs-in-process-css-properties-py
branch
from
66cd049
to
097108d
Compare
weinig
added
WebKit Local Build
WebKit Misc.
|
EWS run on previous version of this PR (hash 097108d)
|
webkit-ews-buildbot
added
the
merging-blocked
weinig
force-pushed
the
eng/Address-FIXMEs-in-process-css-properties-py
branch
from
097108d
to
7eb8cc7
Compare
|
EWS run on previous version of this PR (hash 7eb8cc7) |
darinadler
approved these changes
Nov 14, 2022
weinig
added
merge-queue
weinig
force-pushed
the
eng/Address-FIXMEs-in-process-css-properties-py
branch
from
7eb8cc7
to
34eeee3
Compare
|
EWS run on current version of this PR (hash 34eeee3)
|
https://bugs.webkit.org/show_bug.cgi?id=247861 rdar://102292266 Reviewed by Darin Adler. Address the FIXMEs I left in process-css-properties.py to make the transition from the old script easier. This mostly was removal of unnecessary extra sorting that was done to maintain character for character parity with the old script. Additionally, this removes a bunch of unnecessary list allocations by converting list-comprehension expressions (i.e. [x for x in foo]) into generator-comprehension expressions (i.e. (x for x in foo)) where materializing the list early was not necessary or useful. This allows getting rid of a bunch of caching as well, which is nice. * Source/WebCore/css/process-css-properties.py: Canonical link: https://commits.webkit.org/256763@main
webkit-early-warning-system
force-pushed
the
eng/Address-FIXMEs-in-process-css-properties-py
branch
from
34eeee3
to
b45acc1
Compare
|
Committed 256763@main (b45acc1): https://commits.webkit.org/256763@main Reviewed commits have been landed. Closing PR #6444 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b45acc1
34eeee3
🛠 🧪 win🧪 ios-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2