Remove getPropertyShorthand from the web exposed API. #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinadler
added
528+ (Nightly build)
DOM
|
EWS run on current version of this PR (hash 02a8ab0)
|
darinadler
added
CSS
nt1m
approved these changes
Nov 14, 2022
|
We can remove the silly comment. But more importantly we just need to remove the callers and get rid of the function completely. That’s the way to clean it up. |
|
cc @karlcow here too, to check how web compatible it is (I suspect it is). |
https://bugs.webkit.org/show_bug.cgi?id=87129 rdar://problem/102303976 Reviewed by Tim Nguyen. * LayoutTests/css3/color-filters/color-filter-exposed-if-disabled-expected.txt: Updated. * LayoutTests/css3/color-filters/color-filter-exposed-if-disabled.html: Removed call to getPropertyShorthand. * LayoutTests/css3/color-filters/color-filter-exposed-if-enabled-expected.txt: Updated. * LayoutTests/css3/color-filters/color-filter-exposed-if-enabled.html: Removed call to getPropertyShorthand. * LayoutTests/fast/backgrounds/repeat/background-repeat-shorthand-expected.txt: Removed. * LayoutTests/fast/backgrounds/repeat/background-repeat-shorthand.html: Removed. * LayoutTests/fast/backgrounds/repeat/resources/background-repeat-shorthand.js: Removed. * LayoutTests/fast/css/style-enumerate-properties-expected.txt: Updated. * LayoutTests/fast/css/style-enumerate-properties.html: Removed getPropertyShorthand from the list of property names expected. * Source/WebCore/css/CSSStyleDeclaration.idl: Removed getPropertyShorthand. * Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js: Removed getPropertyShorthand and isPropertyImplicit. Canonical link: https://commits.webkit.org/256636@main
webkit-early-warning-system
force-pushed
the
eng/Remove-getPropertyShorthand-from-the-web-exposed-API-
branch
from
02a8ab0
to
80c7a3d
Compare
|
Committed 256636@main (80c7a3d): https://commits.webkit.org/256636@main Reviewed commits have been landed. Closing PR #6456 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
karlcow
reviewed
Nov 14, 2022
darinadler
deleted the
eng/Remove-getPropertyShorthand-from-the-web-exposed-API-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
80c7a3d
02a8ab0
🧪 ios-wk2🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2