Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Inspector: Cookies for extensions show UUID instead of extension name in Storage tab #6481

Merged
merged 1 commit into from Nov 15, 2022
Merged

Web Inspector: Cookies for extensions show UUID instead of extension name in Storage tab #6481

merged 1 commit into from Nov 15, 2022

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Nov 14, 2022 •
edited by webkit-early-warning-system

6cf49cf

Web Inspector: Cookies for extensions show UUID instead of extension name in Storage tab
https://bugs.webkit.org/show_bug.cgi?id=247903
rdar://101966366

Reviewed by Timothy Hatcher.

`CookieStorageTreeElement` was the only subclass of `StorageTreeElement` not using `WI.displayNameForHost` to generate a
display name, which exists to convert extension UUIDs into a friendly name. Non-extension cookies will still just use
the host for its name.

* Source/WebInspectorUI/UserInterface/Views/CookieStorageTreeElement.js:
(WI.CookieStorageTreeElement.prototype.get name):

Canonical link: https://commits.webkit.org/256695@main

3cfb78c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@patrickangle patrickangle self-assigned this Nov 14, 2022
@patrickangle patrickangle added Web Inspector Bugs related to the WebKit Web Inspector. WebKit Nightly Build labels Nov 14, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 3cfb78c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@patrickangle patrickangle added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 15, 2022
@patrickangle
Web Inspector: Cookies for extensions show UUID instead of extension …
6cf49cf 
…name in Storage tab

https://bugs.webkit.org/show_bug.cgi?id=247903
rdar://101966366

Reviewed by Timothy Hatcher.

`CookieStorageTreeElement` was the only subclass of `StorageTreeElement` not using `WI.displayNameForHost` to generate a
display name, which exists to convert extension UUIDs into a friendly name. Non-extension cookies will still just use
the host for its name.

* Source/WebInspectorUI/UserInterface/Views/CookieStorageTreeElement.js:
(WI.CookieStorageTreeElement.prototype.get name):

Canonical link: https://commits.webkit.org/256695@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256695@main (6cf49cf): https://commits.webkit.org/256695@main

Reviewed commits have been landed. Closing PR #6481 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 6cf49cf into WebKit:main Nov 15, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeenon xeenon xeenon approved these changes

@dcrousso dcrousso Awaiting requested review from dcrousso dcrousso is a code owner

Assignees

@patrickangle patrickangle

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
4 participants
@patrickangle @webkit-early-warning-system @webkit-commit-queue @xeenon