Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Land from branch aliases (Follow-up) #6591

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Nov 17, 2022

@JonWBedard JonWBedard self-assigned this Nov 17, 2022
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Nov 17, 2022
@JonWBedard
Copy link
Member Author

This is looking to fix the problem I saw in this run:
https://ews-build.webkit.org/#/builders/75/builds/2266

Basically, we need to check out the ref of the branch we're using.

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 17, 2022
https://bugs.webkit.org/show_bug.cgi?id=247979
rdar://102419945

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/factories.py:
(MergeQueueFactoryBase.__init__): Map branch alias before checking out branches, but after fetching.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/256797@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Land-from-branch-aliases branch from c33f002 to 3da32ba Compare November 17, 2022 18:42
@webkit-commit-queue
Copy link
Collaborator

Committed 256797@main (3da32ba): https://commits.webkit.org/256797@main

Reviewed commits have been landed. Closing PR #6591 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3da32ba into WebKit:main Nov 17, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 17, 2022
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Land-from-branch-aliases branch November 17, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants