Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(256180@main): Enabling accelerated drawing caused some ImageOnly Failures #6598

Merged

Conversation

robert-jenner
Copy link
Contributor

@robert-jenner robert-jenner commented Nov 17, 2022

6409da4

REGRESSION(256180@main): Enabling accelerated drawing caused some ImageOnly Failures
https://bugs.webkit.org/show_bug.cgi?id=248018
rdar://problem/102449694

Reviewed by Simon Fraser.

Adjusting tolerances for tests that were constant ImageOnlyFailures after accelerated drawing was enabled.

* LayoutTests/compositing/geometry/css-clip-oversize.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html:
* LayoutTests/compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html:
* LayoutTests/css3/blending/background-blend-mode-data-uri-svg-image.html:
* LayoutTests/fast/borders/border-painting-inset.html:
* LayoutTests/fast/borders/border-painting-outset.html:
* LayoutTests/fast/borders/hidpi-border-painting-groove.html:
* LayoutTests/fast/borders/hidpi-border-painting-ridge.html:
* LayoutTests/fast/borders/wrong-border-color-when-radius-is-present.html:
* LayoutTests/fast/box-shadow/inset-shadow-split-inline.html:
* LayoutTests/fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html:
* LayoutTests/imported/blink/fast/sub-pixel/sub-pixel-transparency-layer.html:
* LayoutTests/imported/mozilla/svg/path-02.svg:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/256844@main

8064659

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@robert-jenner robert-jenner self-assigned this Nov 17, 2022
@robert-jenner robert-jenner added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Nov 17, 2022
@robert-jenner robert-jenner added the merge-queue Applied to send a pull request to merge-queue label Nov 18, 2022
…geOnly Failures

https://bugs.webkit.org/show_bug.cgi?id=248018
rdar://problem/102449694

Reviewed by Simon Fraser.

Adjusting tolerances for tests that were constant ImageOnlyFailures after accelerated drawing was enabled.

* LayoutTests/compositing/geometry/css-clip-oversize.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html:
* LayoutTests/compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html:
* LayoutTests/css3/blending/background-blend-mode-data-uri-svg-image.html:
* LayoutTests/fast/borders/border-painting-inset.html:
* LayoutTests/fast/borders/border-painting-outset.html:
* LayoutTests/fast/borders/hidpi-border-painting-groove.html:
* LayoutTests/fast/borders/hidpi-border-painting-ridge.html:
* LayoutTests/fast/borders/wrong-border-color-when-radius-is-present.html:
* LayoutTests/fast/box-shadow/inset-shadow-split-inline.html:
* LayoutTests/fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html:
* LayoutTests/imported/blink/fast/sub-pixel/sub-pixel-transparency-layer.html:
* LayoutTests/imported/mozilla/svg/path-02.svg:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/256844@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256844@main (6409da4): https://commits.webkit.org/256844@main

Reviewed commits have been landed. Closing PR #6598 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 18, 2022
@robert-jenner robert-jenner deleted the eng/102449694 branch November 18, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants