Inline FrameDestructionObserver::frame()

[cdumez]

169f75d

Inline FrameDestructionObserver::frame()
https://bugs.webkit.org/show_bug.cgi?id=240506

Reviewed by Ryosuke Niwa.

Inline FrameDestructionObserver::frame() and it is a trivial getter and it shows on Speedometer
profiles.

* Source/WebKit/Shared/WebsitePoliciesData.cpp:
* Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
* Source/WebKitLegacy/mac/DOM/DOMInternal.mm:
* Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.mm:
* Source/WebCore/Modules/applepay/PaymentSession.cpp:
* Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:
* Source/WebCore/Modules/indexeddb/IDBFactory.cpp:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
* Source/WebCore/Modules/notifications/Notification.cpp:
* Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:
* Source/WebCore/Modules/permissions/PermissionStatus.cpp:
* Source/WebCore/Modules/speech/SpeechRecognition.cpp:
* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
* Source/WebCore/Modules/websockets/WebSocket.cpp:
* Source/WebCore/Modules/websockets/WebSocketChannel.cpp:
* Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/FontFaceSet.cpp:
* Source/WebCore/dom/DataTransfer.cpp:
* Source/WebCore/dom/DataTransferMac.mm:
* Source/WebCore/dom/Document.h:
(WebCore::Document::hasBrowsingContext const): Deleted.
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::hasBrowsingContext const):
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/dom/ViewportArguments.cpp:
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
* Source/WebCore/inspector/InspectorAuditResourcesObject.cpp:
* Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp:
* Source/WebCore/loader/ApplicationManifestLoader.cpp:
* Source/WebCore/loader/ResourceLoader.cpp:
* Source/WebCore/page/FrameDestructionObserver.cpp:
(WebCore::FrameDestructionObserver::frame const): Deleted.
* Source/WebCore/page/FrameDestructionObserver.h:
* Source/WebCore/page/FrameDestructionObserverInlines.h: Copied from Source/WebCore/page/FrameDestructionObserver.h.
(WebCore::FrameDestructionObserver::frame const):
* Source/WebCore/page/UserMessageHandlersNamespace.cpp:
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/testing/js/WebCoreTestSupport.cpp:
* Source/WebCore/workers/service/ServiceWorkerClientData.cpp:
* Source/WebCore/xml/XMLTreeViewer.cpp:
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

Canonical link: https://commits.webkit.org/250693@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[rniwa]

Do we really need Frame.h here??

[cdumez]

I will double check but I believe that's necessary and that's the reason why the inline function is inside FrameDestructionObserverInlines.h and not FrameDestructionObserver.h.

The issue is that m_frame is a WeakPtr<Frame> and you cannot call WeakPtr<Frame>::get() unless Frame is defined.

[rniwa]

Oh, didn't realize it's a WeakPtr. That makes sense.

[cdumez]

I have also just double-checked locally that it doesn't build with a simple Frame forward-declaration.

[rniwa]

r=me

[webkit-early-warning-system]

Committed r294399 (250693@main): https://commits.webkit.org/250693@main

Reviewed commits have been landed. Closing PR #662 and removing active labels.