Make WebCore::FormData::EncodingType an enum class #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddkilzer
added
Forms
|
EWS run on current version of this PR (hash 0f1e3a7) |
|
EWS run on current version of this PR (hash 0f1e3a7) |
|
The bar for this PR was that all ports compiled (as there is no change in functionality), so marking for merge queue. |
https://bugs.webkit.org/show_bug.cgi?id=248086 <rdar://102515978> Reviewed by Chris Dumez. Convert FormData::EncodingType to an enum class so its backing type can be changed to uint8_t. The other changes are to fix the namespace for the enum values. * Source/WebCore/loader/FormSubmission.cpp: (WebCore::FormSubmission::create): * Source/WebCore/platform/network/FormData.h: (WebCore::FormData::EncodingType): * Source/WebCore/platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::addKeyValuePairAsFormData): * Source/WebCore/platform/network/FormDataBuilder.h: Canonical link: https://commits.webkit.org/256852@main
webkit-early-warning-system
force-pushed
the
eng/248086
branch
from
0f1e3a7
to
c965864
Compare
|
Committed 256852@main (c965864): https://commits.webkit.org/256852@main Reviewed commits have been landed. Closing PR #6636 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c965864
0f1e3a7
🧪 ios-wk2🧪 mac-wk1🧪 mac-AS-debug-wk2