Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess test when RunningBoard is enabled. #6675

Merged
merged 1 commit into from Nov 29, 2022
Merged

[macOS] Fix SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess test when RunningBoard is enabled. #6675

merged 1 commit into from Nov 29, 2022

Conversation

salinas-miguel
Copy link
Contributor

@salinas-miguel salinas-miguel commented Nov 19, 2022 •
edited by webkit-early-warning-system

e33ada3

[macOS] Fix SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess test when RunningBoard is enabled.
https://bugs.webkit.org/show_bug.cgi?id=247894
rdar://102320977

Reviewed by Darin Adler and Timothy Hatcher.

This test assumes that all webcontent processes associated with the
service worker have a suspended assertion. However, we currently 'leak'
a foreground assertion on every webcontent process by default when
we build with RunningBoard enabled. We should manually take a suspended
assertion on web content processes associated with this service worker
instead of assuming they already have a suspended assertion.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Canonical link: https://commits.webkit.org/257141@main

5e33972

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@salinas-miguel salinas-miguel self-assigned this Nov 19, 2022
@salinas-miguel salinas-miguel added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Nov 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5e33972)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5e33972)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk1 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 jsc-mips-tests

@darinadler darinadler removed the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Nov 21, 2022
@xeenon xeenon added the Service Workers Component for Service Workers bugs. label Nov 21, 2022
@bnham bnham added the merge-queue Applied to send a pull request to merge-queue label Nov 29, 2022
@salinas-miguel @bnham
[macOS] Fix SuspendServiceWorkerProcessBasedOnClientProcessesWithoutS…
e33ada3 
…eparateServiceWorkerProcess test when RunningBoard is enabled.

https://bugs.webkit.org/show_bug.cgi?id=247894
rdar://102320977

Reviewed by Darin Adler and Timothy Hatcher.

This test assumes that all webcontent processes associated with the
service worker have a suspended assertion. However, we currently 'leak'
a foreground assertion on every webcontent process by default when
we build with RunningBoard enabled. We should manually take a suspended
assertion on web content processes associated with this service worker
instead of assuming they already have a suspended assertion.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Canonical link: https://commits.webkit.org/257141@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the fix-SuspendServiceWorkerProcessBasedOnClientProcessesWithoutSeparateServiceWorkerProcess-Internal branch from 5e33972 to e33ada3 Compare November 29, 2022 22:30
@webkit-commit-queue
Copy link
Collaborator

Committed 257141@main (e33ada3): https://commits.webkit.org/257141@main

Reviewed commits have been landed. Closing PR #6675 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit e33ada3 into WebKit:main Nov 29, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeenon xeenon xeenon approved these changes

@darinadler darinadler darinadler approved these changes

Assignees

@salinas-miguel salinas-miguel

Labels
Service Workers Component for Service Workers bugs.
Projects
None yet
Milestone
No milestone
6 participants
@salinas-miguel @webkit-early-warning-system @webkit-commit-queue @xeenon @darinadler @bnham