Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-animations] implement correct accumulation support for the filter property #6739

Merged
merged 1 commit into from Nov 22, 2022
Merged

[web-animations] implement correct accumulation support for the filter property #6739

merged 1 commit into from Nov 22, 2022

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Nov 22, 2022 •
edited by webkit-early-warning-system

7b53609

[web-animations] implement correct accumulation support for the `filter` property
https://bugs.webkit.org/show_bug.cgi?id=248235

Reviewed by Tim Nguyen.

Implement the specific accumulation behavior for brightness(), contrast(), opacity()
and saturate() operations. We also ensure we have the correct clipping behavior for
various other operations since with accumulation support they could appear out of
bounds.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
* Source/WebCore/platform/graphics/filters/FilterOperation.cpp:
(WebCore::FilterOperation::blendAmounts const):
(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::blend):
* Source/WebCore/platform/graphics/filters/FilterOperation.h:

Canonical link: https://commits.webkit.org/256952@main

d69f5d6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@graouts graouts self-assigned this Nov 22, 2022
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Nov 22, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d69f5d6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk1 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress ⏳ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d69f5d6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 22, 2022
@graouts
[web-animations] implement correct accumulation support for the `filt…
7b53609 
…er` property

https://bugs.webkit.org/show_bug.cgi?id=248235

Reviewed by Tim Nguyen.

Implement the specific accumulation behavior for brightness(), contrast(), opacity()
and saturate() operations. We also ensure we have the correct clipping behavior for
various other operations since with accumulation support they could appear out of
bounds.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
* Source/WebCore/platform/graphics/filters/FilterOperation.cpp:
(WebCore::FilterOperation::blendAmounts const):
(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::blend):
* Source/WebCore/platform/graphics/filters/FilterOperation.h:

Canonical link: https://commits.webkit.org/256952@main
@webkit-commit-queue
Copy link
Collaborator

Committed 256952@main (7b53609): https://commits.webkit.org/256952@main

Reviewed commits have been landed. Closing PR #6739 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7b53609 into WebKit:main Nov 22, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 22, 2022
@graouts graouts deleted the filter-accumulation branch November 22, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@graouts graouts

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
4 participants
@graouts @webkit-early-warning-system @webkit-commit-queue @nt1m