Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type getter is not needed for internal ReadableStream sources #6756

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Type getter is not needed for internal ReadableStream sources #6756

merged 1 commit into from
Nov 28, 2022

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 23, 2022 •
edited by webkit-early-warning-system

f44648f

Type getter is not needed for internal ReadableStream sources
https://bugs.webkit.org/show_bug.cgi?id=248268
rdar://102338913

Reviewed by Eric Carlson.

Make ReadableStreamSource method privates.
In ReadableStream, use @getters instead of private getters to allow getting private values from prototype.
Covered by added test.

* LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt: Added.
* LayoutTests/http/wpt/fetch/fetch-stream-source.html: Added.
* Source/WebCore/Modules/streams/ReadableStream.js:
(initializeReadableStream):
* Source/WebCore/Modules/streams/ReadableStreamSource.idl:
* Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h:
(WebCore::IDLOperationReturningPromise::call):

Canonical link: https://commits.webkit.org/257063@main

a2be9dc

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@youennf youennf requested a review from cdumez as a code owner November 23, 2022 09:56
@youennf youennf self-assigned this Nov 23, 2022
@youennf youennf added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Nov 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a2be9dc)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 23, 2022
@youennf youennf removed the merging-blocked Applied to prevent a change from being merged label Nov 24, 2022
@youennf
Copy link
Contributor Author

youennf commented Nov 25, 2022

Test failures are unrelated

eric-carlson
eric-carlson approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2022
@youennf
Type getter is not needed for internal ReadableStream sources
f44648f 
https://bugs.webkit.org/show_bug.cgi?id=248268
rdar://102338913

Reviewed by Eric Carlson.

Make ReadableStreamSource method privates.
In ReadableStream, use @getterS instead of private getters to allow getting private values from prototype.
Covered by added test.

* LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt: Added.
* LayoutTests/http/wpt/fetch/fetch-stream-source.html: Added.
* Source/WebCore/Modules/streams/ReadableStream.js:
(initializeReadableStream):
* Source/WebCore/Modules/streams/ReadableStreamSource.idl:
* Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h:
(WebCore::IDLOperationReturningPromise::call):

Canonical link: https://commits.webkit.org/257063@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Type-getter-is-not-needed-for-internal-ReadableStream-sources branch from a2be9dc to f44648f Compare November 28, 2022 08:44
@webkit-commit-queue
Copy link
Collaborator

Committed 257063@main (f44648f): https://commits.webkit.org/257063@main

Reviewed commits have been landed. Closing PR #6756 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f44648f into WebKit:main Nov 28, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@youennf youennf

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@youennf @webkit-early-warning-system @webkit-commit-queue @eric-carlson @webkit-ews-buildbot