ReadableStream::pipeTo memory leak #6759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
the
WebCore Misc.
|
EWS run on current version of this PR (hash 0c85a4a) |
achristensen07
approved these changes
Nov 28, 2022
| @@ -84,7 +86,8 @@ class AbortSignal final : public RefCounted<AbortSignal>, public EventTarget, pr | |||
| void eventListenersDidChange() final; | |||
|
|
|||
| bool m_aborted { false }; | |||
| Vector<Algorithm> m_algorithms; | |||
| Vector<std::pair<uint32_t, Algorithm>> m_algorithms; | |||
| uint32_t m_algorithmIdentifier { 0 }; | |||
There was a problem hiding this comment.
Can this be an ObjectIdentifier of some sort?
There was a problem hiding this comment.
I thought about this, the issue is that the algorithm identifier is stored by built-in JS code which only knows about integers, not ObjectIdentifier.
webkit-commit-queue
force-pushed
the
eng/ReadableStreampipeTo-memory-leak
branch
from
0c85a4a
to
d00a3da
Compare
https://bugs.webkit.org/show_bug.cgi?id=247618 rdar://problem/102366716 Reviewed by Alex Christensen. Before the patch, a reference to pipeState would be kept in the AbortSignal. We are now removing the algorithm from thr AbortSignal when finalizing pipeTo to break the reference cycle. * Source/WebCore/Modules/streams/ReadableStreamInternals.js: (readableStreamPipeToWritableStream): (pipeToFinalize): * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSC_DEFINE_HOST_FUNCTION): (WebCore::JSDOMGlobalObject::addBuiltinGlobals): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/AbortSignal.cpp: (WebCore::AbortSignal::signalAbort): (WebCore::AbortSignal::addAbortAlgorithmToSignal): (WebCore::AbortSignal::removeAbortAlgorithmFromSignal): (WebCore::AbortSignal::addAlgorithm): (WebCore::AbortSignal::removeAlgorithm): (WebCore::AbortSignal::whenSignalAborted): Deleted. * Source/WebCore/dom/AbortSignal.h: * Source/WebCore/dom/AbortSignal.idl: Canonical link: https://commits.webkit.org/257109@main
webkit-commit-queue
force-pushed
the
eng/ReadableStreampipeTo-memory-leak
branch
from
d00a3da
to
cb01f4c
Compare
|
Committed 257109@main (cb01f4c): https://commits.webkit.org/257109@main Reviewed commits have been landed. Closing PR #6759 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cb01f4c
0c85a4a