[JSC] Improve resizable TypedArray's slice implementation's spec conformance #6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 1eed6a3) |
rkirsling
approved these changes
Nov 25, 2022
Constellation
added
the
unsafe-merge-queue
…ormance https://bugs.webkit.org/show_bug.cgi?id=248337 rdar://problem/102661384 Reviewed by Ross Kirsling. This patch fixes TypedArray#slice's spec conformance a bit: test length against previously passed value (not updatedLength). We also import new V8 tests more. * JSTests/stress/v8-regress-1376784.js: Added. (test.const.factory.async foo): (test.const.factory): (test): * JSTests/stress/v8-regress-1380398.js: Added. (test): * JSTests/stress/v8-regress-crbug-1359991.js: Added. (MyFloat64Array): * JSTests/stress/v8-regress-crbug-1362487.js: Added. (MyInt8Array): (assertThrows): * JSTests/stress/v8-regress-crbug-1384474-variant2.js: Added. (ta.Symbol.species): (assertThrows): * JSTests/stress/v8-regress-crbug-1384474-variant3.js: Added. (ta.Symbol.species): (assertThrows): * JSTests/stress/v8-regress-crbug-1384474.js: Added. (ta.Symbol.species): (assertThrows): * JSTests/stress/v8-regress-crbug-1392577.js: Added. (start.valueOf): * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h: (JSC::speciesConstruct): (JSC::genericTypedArrayViewProtoFuncSlice): (JSC::genericTypedArrayViewProtoFuncSubarray): Canonical link: https://commits.webkit.org/257018@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Improve-resizable-TypedArrays-slice-implementations-spec-conformance
branch
from
1eed6a3
to
c8c8117
Compare
|
Committed 257018@main (c8c8117): https://commits.webkit.org/257018@main Reviewed commits have been landed. Closing PR #6810 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Improve-resizable-TypedArrays-slice-implementations-spec-conformance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8c8117
1eed6a3
🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2