Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (442fcb1ea6f?): TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is failing #684

Merged
merged 0 commits into from May 18, 2022
Merged

REGRESSION (442fcb1ea6f?): TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is failing #684

merged 0 commits into from May 18, 2022

Conversation

pascoej
Copy link
Member

@pascoej pascoej commented May 17, 2022 •
edited by webkit-early-warning-system

3045bfc

REGRESSION (442fcb1ea6f?): TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is failing
https://bugs.webkit.org/show_bug.cgi?id=240534
rdar://93267243

Reviewed by Brent Fulgham.

The default for a flag relevant to syncing has changed in test infrastructure. This change fixes this test
by using the sync=1 flag as set by default when importing credentials.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/250714@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pascoej pascoej self-assigned this May 17, 2022
@pascoej pascoej added WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). WebKit Nightly Build labels May 17, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 18, 2022
brentfulgham
brentfulgham approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brentfulgham
Copy link
Contributor

Although this iOS-wk2 crash looks suspicious (http/wpt/webauthn/public-key-credential-unfocused-document.https.html]), the actual crash is a GPU process crash, which can't be due to this keychain function call.

@pascoej pascoej added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels May 18, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-442fcb1ea6f-TestWebKitAPI-WebAuthenticationPanel-ExportImportDuplicateCredential-is-failing branch from d256575 to 3045bfc Compare May 18, 2022 21:29
@webkit-early-warning-system webkit-early-warning-system merged commit 3045bfc into WebKit:main May 18, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294434 (250714@main): https://commits.webkit.org/250714@main

Reviewed commits have been landed. Closing PR #684 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

Assignees

@pascoej pascoej

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
3 participants
@pascoej @brentfulgham @webkit-early-warning-system