Upgrade to sandbox version 3 on iOS and macOS #6864

pvollan · 2022-11-28T16:28:45Z

`129d762`

Upgrade to sandbox version 3 on iOS and macOS
https://bugs.webkit.org/show_bug.cgi?id=248399
rdar://102719029

Reviewed by Brent Fulgham.

Upgrade to sandbox version 3 on iOS and macOS. This patch should not introduce any behavior change, since
the resources with implicit access in version 1 has been explicitly allowed. Also, this patch adds more
sandbox include files to be able to share common rules.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Shared/Sandbox/iOS/common.sb
* Source/WebKit/Shared/Sandbox/macOS/common.sb:
* Source/WebKit/Shared/Sandbox/util.sb
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/257272@main

509c22f

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-28T16:28:50Z

EWS run on previous version of this PR (hash a76df67)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-28T19:35:25Z

EWS run on previous version of this PR (hash 0210043)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-29T09:17:36Z

EWS run on previous version of this PR (hash 4cca556)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-29T10:23:22Z

EWS run on previous version of this PR (hash e4481f1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	~~🧪 jsc-armv7-tests~~
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-29T11:36:36Z

EWS run on previous version of this PR (hash 5dabc34)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 api-mac~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-29T18:12:15Z

EWS run on previous version of this PR (hash f5ab65a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	~~🛠 gtk~~	💥 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-30T12:42:27Z

EWS run on previous version of this PR (hash f3ab20e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-30T13:56:27Z

EWS run on previous version of this PR (hash f8c5031)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
~~🛠 🧪 merge~~	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

brentfulgham

A very nice cleanup! r=me

brentfulgham · 2022-11-30T17:11:25Z

Source/WTF/wtf/PlatformUse.h

@@ -375,3 +375,8 @@
 #if PLATFORM(COCOA) && (HAVE(CGSTYLE_CREATE_SHADOW2) || HAVE(CGSTYLE_COLORMATRIX_BLUR))
 #define USE_GRAPHICS_CONTEXT_FILTERS 1
 #endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 140000) \
+    || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 170000)


I am always confused by when to use PLATFORM(IOS_FAMILY) versus PLATFORM(IOS). I believe that this rule means that USE_SANDBOX_VERSION_3 will be undefined for watchOS and tvOS. Is this your intention?

I am always confused by when to use PLATFORM(IOS_FAMILY) versus PLATFORM(IOS). I believe that this rule means that USE_SANDBOX_VERSION_3 will be undefined for watchOS and tvOS. Is this your intention?

That is a good point. The intention is for also watchOS and tvOS to have version 3. I have removed this from the latest patch, and will enable in a separate patch.

Thanks for reviewing!

brentfulgham · 2022-11-30T17:12:45Z

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in

+
+(with-filter (mac-policy-name "Sandbox")
+    (allow system-mac-syscall (mac-syscall-number 5)))
+#endif

 ;;;
 ;;; The following rules were originally contained in 'common.sb'. We are duplicating them here so we can
 ;;; remove unneeded sandbox extensions.
 ;;;


Perhaps this comment should move to Shared/Sandbox/iOS/common.sb, too?

There are still quite a few rules that were not moved to Shared/Sandbox/iOS/common.sb in this patch, so I think we may leave the comment for now. However, we should move all the common rules to the new file including the comment. I will address that in a separate patch.

Thanks for reviewing!

brentfulgham · 2022-11-30T17:14:01Z

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in


 (allow system-privilege (with grant)
    (require-all
        (privilege-id PRIV_NET_PRIVILEGED_SOCKET_DELEGATE)
        (require-entitlement "com.apple.private.network.socket-delegate")))

-;; Silence spurious logging due to rdar://20117923 and rdar://72366475
-(deny system-privilege (privilege-id PRIV_GLOBAL_PROC_INFO) (with no-report))
-
 ;;;
 ;;; The following rules were originally contained in 'common.sb'. We are duplicating them here so we can
 ;;; remove unneeded sandbox extensions.
 ;;;


Ditto: Perhaps move the comment to Shared/Sandbox/iOS/common.sb as well?

brentfulgham · 2022-11-30T17:14:53Z

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

-(deny system-privilege (privilege-id PRIV_GLOBAL_PROC_INFO) (with no-report))
+#if USE(SANDBOX_VERSION_3)
+(allow dynamic-code-generation)
+#endif

 ;;;
 ;;; The following rules were originally contained in 'common.sb'. We are duplicating them here so we can
 ;;; remove unneeded sandbox extensions.
 ;;;


Ditto: move comment to Shared/Sandbox/iOS/common.sb.

webkit-early-warning-system · 2022-12-01T09:25:00Z

EWS run on current version of this PR (hash 509c22f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	🛠 mac	🛠 wpe	⏳ 🛠 🧪 win
⏳ 🧪 bindings	🛠 ios-sim	🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
🧪 webkitperl	🧪 ios-wk2	🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	🧪 api-ios	🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	🛠 tv	🧪 mac-wk1
🧪 services	⏳ 🛠 tv-sim	🧪 mac-wk2
	🛠 watch	🧪 mac-AS-debug-wk2
	🛠 watch-sim	🧪 mac-wk2-stress

webkit-early-warning-system · 2022-12-01T09:25:02Z

EWS run on current version of this PR (hash 509c22f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=248399 rdar://102719029 Reviewed by Brent Fulgham. Upgrade to sandbox version 3 on iOS and macOS. This patch should not introduce any behavior change, since the resources with implicit access in version 1 has been explicitly allowed. Also, this patch adds more sandbox include files to be able to share common rules. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Shared/Sandbox/iOS/common.sb * Source/WebKit/Shared/Sandbox/macOS/common.sb: * Source/WebKit/Shared/Sandbox/util.sb * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/257272@main

webkit-commit-queue · 2022-12-02T07:00:45Z

Committed 257272@main (129d762): https://commits.webkit.org/257272@main

Reviewed commits have been landed. Closing PR #6864 and removing active labels.

pvollan requested a review from cdumez as a code owner November 28, 2022 16:28

pvollan self-assigned this Nov 28, 2022

pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Nov 28, 2022

pvollan marked this pull request as draft November 28, 2022 16:28

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 28, 2022

pvollan removed the merging-blocked Applied to prevent a change from being merged label Nov 28, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from a76df67 to 0210043 Compare November 28, 2022 19:34

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 28, 2022

pvollan removed the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from 0210043 to 4cca556 Compare November 29, 2022 09:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022

pvollan removed the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from 4cca556 to e4481f1 Compare November 29, 2022 10:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022

pvollan removed the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from e4481f1 to 5dabc34 Compare November 29, 2022 11:36

pvollan requested a review from gavin-apple November 29, 2022 12:01

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from 5dabc34 to f5ab65a Compare November 29, 2022 18:11

pvollan requested a review from geoffreygaren November 29, 2022 18:12

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022

pvollan removed the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from f5ab65a to f3ab20e Compare November 30, 2022 12:42

pvollan requested a review from szewai November 30, 2022 12:42

pvollan requested a review from brentfulgham November 30, 2022 12:42

pvollan marked this pull request as ready for review November 30, 2022 12:43

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from f3ab20e to f8c5031 Compare November 30, 2022 13:55

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022

brentfulgham approved these changes Nov 30, 2022

View reviewed changes

pvollan added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Dec 1, 2022

pvollan force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from f8c5031 to 509c22f Compare December 1, 2022 09:24

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 2, 2022

pvollan added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 2, 2022

webkit-early-warning-system force-pushed the eng/Upgrade-to-sandbox-version-3-on-iOS-and-macOS branch from 509c22f to 129d762 Compare December 2, 2022 07:00

webkit-early-warning-system merged commit 129d762 into WebKit:main Dec 2, 2022

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to sandbox version 3 on iOS and macOS #6864

Upgrade to sandbox version 3 on iOS and macOS #6864

pvollan commented Nov 28, 2022 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Nov 28, 2022 •

edited

webkit-early-warning-system commented Nov 28, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 30, 2022 •

edited

webkit-early-warning-system commented Nov 30, 2022 •

edited

brentfulgham left a comment

brentfulgham Nov 30, 2022

pvollan Dec 1, 2022

brentfulgham Nov 30, 2022

pvollan Dec 1, 2022

brentfulgham Nov 30, 2022

brentfulgham Nov 30, 2022

webkit-early-warning-system commented Dec 1, 2022 •

edited

webkit-early-warning-system commented Dec 1, 2022 •

edited

webkit-commit-queue commented Dec 2, 2022

Upgrade to sandbox version 3 on iOS and macOS #6864

Upgrade to sandbox version 3 on iOS and macOS #6864

Conversation

pvollan commented Nov 28, 2022 • edited by webkit-early-warning-system

129d762

webkit-early-warning-system commented Nov 28, 2022 • edited

webkit-early-warning-system commented Nov 28, 2022 • edited

webkit-early-warning-system commented Nov 29, 2022 • edited

webkit-early-warning-system commented Nov 29, 2022 • edited

webkit-early-warning-system commented Nov 29, 2022 • edited

webkit-early-warning-system commented Nov 29, 2022 • edited

webkit-early-warning-system commented Nov 30, 2022 • edited

webkit-early-warning-system commented Nov 30, 2022 • edited

brentfulgham left a comment

Choose a reason for hiding this comment

brentfulgham Nov 30, 2022

Choose a reason for hiding this comment

pvollan Dec 1, 2022

Choose a reason for hiding this comment

brentfulgham Nov 30, 2022

Choose a reason for hiding this comment

pvollan Dec 1, 2022

Choose a reason for hiding this comment

brentfulgham Nov 30, 2022

Choose a reason for hiding this comment

brentfulgham Nov 30, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Dec 1, 2022 • edited

webkit-early-warning-system commented Dec 1, 2022 • edited

webkit-commit-queue commented Dec 2, 2022

pvollan commented Nov 28, 2022 •

edited by webkit-early-warning-system

`129d762`

webkit-early-warning-system commented Nov 28, 2022 •

edited

webkit-early-warning-system commented Nov 28, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 29, 2022 •

edited

webkit-early-warning-system commented Nov 30, 2022 •

edited

webkit-early-warning-system commented Nov 30, 2022 •

edited

webkit-early-warning-system commented Dec 1, 2022 •

edited

webkit-early-warning-system commented Dec 1, 2022 •

edited