Create GraphicsClient for the graphics specific subset of ChromeClient that needs to be accessed from worker threads. #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwoodrow
added
the
Layout and Rendering
|
EWS run on previous version of this PR (hash 6d456fe)
|
kkinnunen-apple
approved these changes
Nov 28, 2022
| @@ -46,13 +46,14 @@ class TextStream; | |||
| namespace WebCore { | |||
|
|
|||
| class GraphicsContext; | |||
| class HostWindow; | |||
| class GraphicsClient; | |||
There was a problem hiding this comment.
This is not needed ..
mattwoodrow
force-pushed
the
eng/graphics-client
branch
from
6d456fe
to
a6d6f22
Compare
|
EWS run on current version of this PR (hash a6d6f22)
|
…t that needs to be accessed from worker threads. https://bugs.webkit.org/show_bug.cgi?id=248415 Reviewed by Kimmo Kinnunen. Creates new subclass for HostWindow 'GraphicsClient', for the graphics specific subset. This currently only has createImageBuffer, but in the future will have other graphics-related WebKit functionality (like creating a WebGL context). * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSFilterImageValue.cpp: * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer const): * Source/WebCore/html/ImageBitmap.cpp: (WebCore::ImageBitmap::createImageBuffer): (WebCore::ImageBitmap::createPromise): * Source/WebCore/html/ImageBitmap.h: * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::transferToImageBitmap): (WebCore::OffscreenCanvas::createImageBuffer const): * Source/WebCore/platform/GraphicsClient.h: Added. * Source/WebCore/page/Chrome.h: * Source/WebCore/platform/HostWindow.h: * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::create): * Source/WebCore/platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::CreationContext::CreationContext): * Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp: (WebCore::ImageBufferIOSurfaceBackend::create): * Source/WebCore/platform/graphics/cocoa/IOSurface.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: (WebCore::IOSurface::ensurePlatformContext): Canonical link: https://commits.webkit.org/257096@main
webkit-early-warning-system
force-pushed
the
eng/graphics-client
branch
from
a6d6f22
to
0192c42
Compare
|
Committed 257096@main (0192c42): https://commits.webkit.org/257096@main Reviewed commits have been landed. Closing PR #6875 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0192c42
a6d6f22
🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress