REGRESSION (255903@main): iWork/Numbers/Pages Keynote attachments appear upside down #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoucht
changed the title
|
EWS run on previous version of this PR (hash ffd5810) |
nmoucht
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
ffd5810
to
43a5a21
Compare
nmoucht
added
the
New Bugs
|
EWS run on previous version of this PR (hash 43a5a21) |
nmoucht
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
43a5a21
to
3879e0b
Compare
|
EWS run on previous version of this PR (hash 3879e0b) |
webkit-ews-buildbot
added
the
merging-blocked
nmoucht
removed
the
merging-blocked
nmoucht
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
3879e0b
to
8154390
Compare
|
EWS run on previous version of this PR (hash 8154390)
|
nmoucht
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
8154390
to
1b3d366
Compare
|
EWS run on current version of this PR (hash 1b3d366)
|
nmoucht
added
the
unsafe-merge-queue
webkit-early-warning-system
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
1b3d366
to
5bd5d88
Compare
…ear upside down https://bugs.webkit.org/show_bug.cgi?id=248421 <rdar://102052562> Unreviewed revert. Revert 255903@main. * LayoutTests/fast/attachment/mac/attachment-element-gpu-process-expected.html: Removed. * LayoutTests/fast/attachment/mac/attachment-element-gpu-process.html: Removed. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/rendering/AttachmentLayout.h: Removed. * Source/WebCore/rendering/AttachmentLayout.mm: Removed. * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::paintAttachmentText): Deleted. * Source/WebCore/rendering/RenderThemeCocoa.h: * Source/WebCore/rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::attachmentBaseline const): Deleted. (WebCore::RenderThemeCocoa::paintAttachmentText): Deleted. * Source/WebCore/rendering/RenderThemeIOS.h: * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::attachmentActionFont): (WebCore::attachmentActionColor): (WebCore::attachmentTitleFont): (WebCore::shortCaptionPointSizeWithContentSizeCategory): (WebCore::attachmentDynamicTypeScaleFactor): (WebCore::attachmentTitleColor): (WebCore::attachmentSubtitleFont): (WebCore::attachmentSubtitleColor): (WebCore::RenderAttachmentInfo::addLine): (WebCore::RenderAttachmentInfo::buildWrappedLines): (WebCore::RenderAttachmentInfo::buildSingleLine): (WebCore::getAttachmentProgress): (WebCore::RenderAttachmentInfo::RenderAttachmentInfo): (WebCore::RenderThemeIOS::attachmentBaseline const): (WebCore::paintAttachmentIcon): (WebCore::paintAttachmentText): (WebCore::paintAttachmentProgress): (WebCore::attachmentBorderPath): (WebCore::RenderThemeIOS::paintAttachment): * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::titleTextColorForAttachment): (WebCore::AttachmentLayout::addTitleLine): (WebCore::AttachmentLayout::layOutTitle): (WebCore::AttachmentLayout::layOutSubtitle): (WebCore::AttachmentLayout::AttachmentLayout): (WebCore::RenderThemeMac::attachmentBaseline const): (WebCore::paintAttachmentIcon): (WebCore::paintAttachmentTitle): (WebCore::paintAttachmentSubtitle): (WebCore::RenderThemeMac::paintAttachment): Canonical link: https://commits.webkit.org/257095@main
webkit-early-warning-system
force-pushed
the
eng/REGRESSION-255903main-iWorkNumbersPages-Keynote-attachments-appear-upside-down
branch
from
5bd5d88
to
f3dfd0c
Compare
|
Committed 257095@main (f3dfd0c): https://commits.webkit.org/257095@main Reviewed commits have been landed. Closing PR #6882 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f3dfd0c
1b3d366
🛠 ios🛠 mac🛠 wpe🛠 🧪 win🛠 mac-debug🛠 gtk🛠 wincairo🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 tv🧪 mac-wk1🛠 tv-sim🧪 mac-wk2🛠 watch🧪 mac-AS-debug-wk2🧪 mac-wk2-stress