Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Live Range Selection] fast/replaced/selection-rect-transform.html fails #6898

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[Live Range Selection] fast/replaced/selection-rect-transform.html fails #6898

merged 1 commit into from
Nov 29, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Nov 29, 2022 •
edited by webkit-early-warning-system

1797147

[Live Range Selection] fast/replaced/selection-rect-transform.html fails
https://bugs.webkit.org/show_bug.cgi?id=248443

Reviewed by Darin Adler.

Use Range's selectNode function to select the image element instead of
relying on legacy editing offset - (img, 1) to mean the position after img -
since that will break once live range selection is enabled.

* LayoutTests/fast/replaced/selection-rect-transform.html:

Canonical link: https://commits.webkit.org/257137@main

4302597

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa self-assigned this Nov 29, 2022
@rniwa rniwa added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Nov 29, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4302597)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa assigned darinadler and unassigned darinadler Nov 29, 2022
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 29, 2022
@rniwa
[Live Range Selection] fast/replaced/selection-rect-transform.html fails
1797147 
https://bugs.webkit.org/show_bug.cgi?id=248443

Reviewed by Darin Adler.

Use Range's selectNode function to select the image element instead of
relying on legacy editing offset - (img, 1) to mean the position after img -
since that will break once live range selection is enabled.

* LayoutTests/fast/replaced/selection-rect-transform.html:

Canonical link: https://commits.webkit.org/257137@main
@webkit-early-warning-system webkit-early-warning-system merged commit 1797147 into WebKit:main Nov 29, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257137@main (1797147): https://commits.webkit.org/257137@main

Reviewed commits have been landed. Closing PR #6898 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 29, 2022
@rniwa rniwa deleted the fix248443 branch November 29, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@rniwa rniwa

Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @darinadler